Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 361606

Summary: Failures from fix 358545
Product: [WebTools] JSDT Reporter: Nitin Dahyabhai <thatnitind>
Component: WebAssignee: Nitin Dahyabhai <thatnitind>
Status: CLOSED FIXED QA Contact: Nitin Dahyabhai <thatnitind>
Severity: blocker    
Priority: P3 CC: cbridgha, cmjaun, david_williams, raghunathan.srinivasan
Version: 3.2.5Flags: david_williams: pmc_approved+
raghunathan.srinivasan: pmc_approved+
thatnitind: pmc_approved? (naci.dai)
thatnitind: pmc_approved? (deboer)
thatnitind: pmc_approved? (neil.hauge)
thatnitind: pmc_approved? (kaloyan)
thatnitind: pmc_approved? (cbridgha)
cmjaun: review+
Target Milestone: 3.2.5   
Hardware: All   
OS: All   
Whiteboard: PMC_approved
Bug Depends on:    
Bug Blocks: 358545    
Attachments:
Description Flags
rollback of FormattingStrategyJSDT.java
none
Bundle manifest updates to increment versions none

Description Nitin Dahyabhai CLA 2011-10-21 01:58:17 EDT 
Created attachment 205684 [details]
rollback of FormattingStrategyJSDT.java

Fixing bug 358545 included changes to FormattingStrategyJSDT which have caused a number of failures and errors in the JSDT Web UI tests.  Rolling back the changes to that file specifically allows the broken suite to pass and the new test cases from that fix to also pass without further modification.
Comment 1 Nitin Dahyabhai CLA 2011-10-21 11:52:54 EDT 
Created attachment 205742 [details]
Bundle manifest updates to increment versions
Comment 2 Nitin Dahyabhai CLA 2011-10-21 12:36:44 EDT 
*Explain why you believe this is a stop-ship defect. Or, if it is a "hotbug" (requested by an adopter) please document it as such.

Web page formatting in HTML files is broken, or now has different results than before.

*Is there a work-around? If so, why do you believe the work-around is insufficient?

No workaround.

*How has the fix been tested? Is there a test case attached to the bugzilla record? 

Ad-hoc.

*Has a JUnit Test been added?

No.

*Give a brief technical overview. Who has reviewed this fix?

We're rolling back the changes to the JSDT formatter that tried to constrain the formatting edits more than before.  The tests added for bug 358545 continue to pass, and the original suite that escaped my attention and has errors/failures now runs successfully.  Chris has reviewed it.

*What is the risk associated with this fix?

Low.  We're backing out previous changes.
Comment 3 David Williams CLA 2011-10-21 12:58:21 EDT 
Sounds ok to me, to roll-back the fix ... but, bug 358545 sounds pretty serious too. I assume you (we) will just "live with that" rather introduce a regression? That is, there is no alternative fix coming for this release, I assume?
Comment 4 Nitin Dahyabhai CLA 2011-10-21 13:03:51 EDT 
(In reply to comment #3)
> Sounds ok to me, to roll-back the fix ... but, bug 358545 sounds pretty serious
> too. I assume you (we) will just "live with that" rather introduce a
> regression? That is, there is no alternative fix coming for this release, I
> assume?

Bug 358545 remains fixed with the rollback.  The tests added for it specifically look for content being lost during formatting.
Comment 5 David Williams CLA 2011-10-21 13:23:32 EDT 
Ah, just rolling back part of the fix then. Thanks for clarifying. Good that bug remains fixed. 

I'll assume "no more work is needed" then. If in fact, something is still required, some other tweaking to get the changes originally thought needed for FormattingStrategyJSDT, then it'd be nice if you opened a new bug for that, and cross referenced here. But, good if "all done" and the changes originally thought needed for FormattingStrategyJSDT simply were not needed.
Comment 6 Nitin Dahyabhai CLA 2011-10-21 13:26:32 EDT 
(In reply to comment #5)
> I'll assume "no more work is needed" then.

Yep.
Comment 7 Nitin Dahyabhai CLA 2011-10-21 13:29:02 EDT 
Released at +2.
Comment 8 Nitin Dahyabhai CLA 2011-10-23 18:18:49 EDT 
Verified with M-3.2.5-20111021173028