Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 361536

Summary: avoid nested scrollbars when expanding "Advanced" section when adding an attachment with long comment
Product: z_Archived Reporter: Tomasz Zarna <tomasz.zarna>
Component: MylynAssignee: Tomasz Zarna <tomasz.zarna>
Status: RESOLVED FIXED QA Contact:
Severity: minor    
Priority: P3 CC: b.muskalla, steffen.pingel
Version: unspecifiedKeywords: contributed
Target Milestone: 3.7   
Hardware: PC   
OS: Windows XP   
URL: http://review.mylyn.org/#change,89
Whiteboard:
Attachments:
Description Flags
Add Attachment dialog
none
The diff
steffen.pingel: iplog+
mylyn/context/zip none

Description Tomasz Zarna CLA 2011-10-20 08:59:58 EDT 
Mylyn 3.7.0.I20111015-0643

Steps:
1. On the Task editor press the Attach... button
2. Navigate to the "Attachment Details" page
3. Enter at least 2 lines long comment
4. Expand the "Advanced" section
=> IS: a horizontal scroll bar shows up, the Comment field gets extremely long
=> SHOULD BE: none of the above, except for the "Advanced" section expanded
Comment 1 Tomasz Zarna CLA 2011-10-20 09:01:19 EDT 
Created attachment 205621 [details]
Add Attachment dialog
Comment 2 Steffen Pingel CLA 2011-10-20 09:35:52 EDT 
Agreed, the resizing behavior of the dialog should be improved. Implementation-wise the code should reuse the SectionComposite from the commons that has some support for handling scrollbars and resizing.
Comment 3 Steffen Pingel CLA 2011-10-26 16:47:59 EDT 
Suggested change looks good. Can you add your name to the copyright header and then drag and drop the commit to attach it to this bug so we can track the contribution? I'll then go ahead and apply the change. Thanks!
Comment 4 Tomasz Zarna CLA 2011-10-27 16:46:30 EDT 
Created attachment 206094 [details]
The diff

(In reply to comment #3)
> Can you add your name to the copyright header 

Done in the latest patch set.

> and then drag and drop the commit to attach it to this bug 

I wish I could. D'n'd did work but the commit content wasn't mine. It looked like a different commit, and it wasn't the previous one, go figure! So, I'm attaching a manually created diff. I hope it's ok.
Comment 5 Tomasz Zarna CLA 2011-10-27 16:46:34 EDT 
Created attachment 206095 [details]
mylyn/context/zip
Comment 6 Steffen Pingel CLA 2011-10-28 09:10:01 EDT 
Thanks! I have applied the patch to master.

(In reply to comment #4)
...
> > and then drag and drop the commit to attach it to this bug
> 
> I wish I could. D'n'd did work but the commit content wasn't mine. It looked
> like a different commit, and it wasn't the previous one, go figure! 

Benjamin, do you have any thoughts why this produced an unexpected result?
Comment 7 Benjamin Muskalla CLA 2011-10-28 11:33:06 EDT 
No idea. Tomasz, would be awesome if you can open a bug at EGit (and cc me) for that and tell me what HEAD~1 in your case was (I assume you were one commit away from origin/master with your HEAD).
Comment 8 Tomasz Zarna CLA 2011-10-28 12:07:35 EDT 
(In reply to comment #7)
> Tomasz, would be awesome if you can open a bug at EGit (and cc me)

Sure, it's bug 362338.
Comment 9 Benjamin Muskalla CLA 2011-10-28 12:35:20 EDT 
Great thanks