Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 361509

Summary: [Xtext] quick-fix proposals for linker errors are not transformed with the rule specific ValueConverter for qualified names.
Product: [Modeling] TMF Reporter: Ralf Weisheit <r.wt>
Component: XtextAssignee: Project Inbox <tmf.xtext-inbox>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: sebastian.zarnekow
Version: 2.0.0Flags: sebastian.zarnekow: juno+
Target Milestone: M7   
Hardware: PC   
OS: Windows 7   
Whiteboard:
Attachments:
Description Flags
override DefaultQuickfixProvider.createLinkingIssueResolutions to solve the bug none

Description Ralf Weisheit CLA 2011-10-20 05:03:06 EDT
Build Identifier: 20110916-0149

When a fragment of a qualified name consists in a keyword, or the concrete syntax defines a different delimiter, the rules ValueConverter for qualified names transforms to the proper internal String representation. The quick-fix provider for linker errors pushes this internal String representation to the document instead of transforming it via the ValueConverter. So Caret chars were not added and delimiter were not replaced.

In my project I have developed a generic bug fix by overwriting DefaultQuickfixProvider.createLinkingIssueResolutions. It is not trivial because some interfaces had to be changed. If you are interested I can provide the fix.

Reproducible: Always

Steps to Reproduce:
1. define a object that has keywords in its qualified name
2. define a cross reference using this name
3. modify the cross reference so a linker error appears
4. select a quick-fix proposal with that mane
==> the internal representation will be added to the document
Comment 1 Ralf Weisheit CLA 2011-10-20 05:15:09 EDT
Created attachment 205596 [details]
override DefaultQuickfixProvider.createLinkingIssueResolutions to solve the bug
Comment 2 Sebastian Zarnekow CLA 2012-04-03 17:22:42 EDT
we have to deal with keywords as cross reference terminal and ignore case linking, too.
Comment 3 Sebastian Zarnekow CLA 2012-04-03 17:47:26 EDT
Pushed to master.
Comment 4 Karsten Thoms CLA 2017-09-19 17:53:29 EDT
Closing all bugs that were set to RESOLVED before Neon.0
Comment 5 Karsten Thoms CLA 2017-09-19 18:04:11 EDT
Closing all bugs that were set to RESOLVED before Neon.0