Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 361481

Summary:	new file and folder prompts are dialogs rather than edit fields
Product:	[ECD] Orion	Reporter:	Susan McCourt <susan>
Component:	Client	Assignee:	Susan McCourt <susan>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	mamacdon, simon_kaegi
Version:	unspecified	Flags:	mamacdon: review+ simon_kaegi: review+
Target Milestone:	0.3 RC3
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Susan McCourt

2011-10-19 18:02:47 EDT

somewhere along the line, we've lost the "insert edit field next to new command" behavior and instead we are getting window.prompt for new file and folder names.  Bummer.  I don't see a change in fileCommands, so I suspect the dom id changed (perhaps command framework changes?) and therefore it defaults to the window.prompt because it can't figure out where to insert the box.

Comment 1 Susan McCourt

2011-10-19 18:03:15 EDT

I'd like to look at this for RC3 because I think it's a recent regression.

Comment 2 Susan McCourt

2011-10-19 18:33:01 EDT

this was working in v20111004-2009, and broken in v20111004-2139

Comment 3 Susan McCourt

2011-10-19 18:59:22 EDT

This was broken by some sloppy cut and paste in my sprite refactoring.  
As part of that code, I only create an image element for a command if it's needed (before we always had one, even an empty one, for text links).

When moving that code around, I accidentally put the setting of the link id in the conditional part where the image code goes.

This means that text link commands (such as most toolbar commands) no longer had their id assigned to the link, which in turn meant there was no id being passed to the handler, and therefore the code that looked up a dom id to decide where to put the edit box couldn't find anything.

Moved the id code back outside of the conditional.

Adding mark for review.

Comment 4 Susan McCourt

2011-10-19 18:59:55 EDT

Adding Simon for approval.  Assuming Mark approves it, are you okay?  this is a regression introduced in RC1 and it's a one liner to fix it.

Comment 5 Mark Macdonald

2011-10-19 19:40:45 EDT

+1 from me

Tested various ways to launch commands and they all worked.

Comment 6 Susan McCourt

2011-10-19 22:45:57 EDT

pushed to master.