Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 361466

Summary: ensure that desktop search feature is installable on Linux and Mac
Product: z_Archived Reporter: David Green <greensopinion>
Component: MylynAssignee: David Green <greensopinion>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: shawn.minto, steffen.pingel
Version: unspecified   
Target Milestone: 3.7   
Hardware: PC   
OS: Linux   
Whiteboard:
Bug Depends on:    
Bug Blocks: 349351    
Attachments:
Description Flags
results of running a search on Linux none

Description David Green CLA 2011-10-19 15:52:51 EDT 
Installation of Desktop Search fails on mac with the following exception:

pre. 
Cannot complete the install because one or more required items could not be found.
  Software being installed: Mylyn Desktop Search (Incubation) 3.7.0.I20111019-1902 (org.eclipse.mylyn.sandbox.search.feature.group 3.7.0.I20111019-1902)
  Missing requirement: Mylyn Desktop Search (Incubation) 3.7.0.I20111019-1902 (org.eclipse.mylyn.sandbox.search.feature.group 3.7.0.I20111019-1902) requires 'org.eclipse.mylyn.sandbox.search.ui.windows [3.7.0.I20111019-1902]' but it could not be found
Comment 1 David Green CLA 2011-10-20 12:21:15 EDT 
Steffen, any suggestions on how to deal with this?  What I've got now is the following structure:

* Desktop Search Feature @/org.eclipse.mylyn.sandbox.search-feature@
** Search API, Default provider @/org.eclipse.mylyn.sandbox.search.ui@
** Windows-specific search provider @/org.eclipse.mylyn.sandbox.search.ui.windows@

I'd like to have a single feature for people to choose on the update site, but have the Windows-specific plug-in only be installed on Windows.  I don't see any easy way of doing this.  From what I can see we have the following choices:

* create two features with the same name, and use platform filters to make only one of them show up in the p2 install software wizard
* keep the single feature format, but only specify the platform-independent plug-in and add an optional bundle dependency on the windows-specific plug-in (is there a way to make it greedy?)

Neither option sounds all that great to me - ideas?
Comment 2 David Green CLA 2011-10-20 13:00:39 EDT 
I should have looked at the PDE editor for features... it's right there in the UI

bc. <plugin
         id="..."
         os="win32"
         arch="x86" .../>
Comment 3 Steffen Pingel CLA 2011-10-20 18:10:17 EDT 
That sounds right. We had problems building features that specified platform filters for plug-in in the past but recent Tycho versions may support that better.
Comment 4 David Green CLA 2011-10-20 18:48:25 EDT 
The build succeeded, however I'm still seeing the following error on Linux:

pre. 
Cannot complete the install because one or more required items could not be found.
  Software being installed: Mylyn Desktop Search (Incubation) 3.7.0.I20111020-1706 (org.eclipse.mylyn.sandbox.search.feature.group 3.7.0.I20111020-1706)
  Missing requirement: Mylyn Desktop Search (Incubation) 3.7.0.I20111020-1706 (org.eclipse.mylyn.sandbox.search.feature.group 3.7.0.I20111020-1706) requires org.eclipse.mylyn.sandbox.search.ui.windows [3.7.0.I20111020-1706]' but it could not be found
  
Works fine for me on Windows.  Any ideas?
Comment 5 David Green CLA 2011-10-27 17:26:02 EDT 
looks like this was PEBKAC... I just didn't push the right changeset.  It's up and working now, installable on Linux confirmed.
Comment 6 David Green CLA 2011-10-27 17:26:31 EDT 
Created attachment 206098 [details]
results of running a search on Linux