Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 361448

Summary:	Keybinding doesn't appear in the debug toolbar
Product:	[Eclipse Project] Platform	Reporter:	Remy Suen <remy.suen>
Component:	Debug	Assignee:	Pawel Piech <pawel.1.piech>
Status:	VERIFIED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	daniel_megert, Michael_Rennie, pawel.1.piech, pwebster
Version:	3.8	Flags:	Michael_Rennie: review+
Target Milestone:	3.8 M3
Hardware:	PC
OS:	Windows XP
Whiteboard:

Description Remy Suen

2011-10-19 14:08:37 EDT

I20111018-0850

1. Window > Open Perspective > Debug
2. Window > Preferences > General > Keys
3. Bind 'Suspend' to Ctrl+F12 (or some other non-conflicting keybinding).
4. Click 'OK'.
5. Hover over the 'Suspend' tool item, the keybinding doesn't show up. Before you ask, the keybinding will not show up regardless of the tool item's enablement state.

Comment 1 Remy Suen

2011-10-19 14:45:55 EDT

'Terminate' has its keybinding shown.

I suspect this is because TerminateCommandAction actually defines a valid and correct action definition id. Most other DebugCommandActions don't do this. Also see bug 361424.

Comment 2 Pawel Piech

2011-10-19 16:12:22 EDT

Thanks, I just found the mismatch in command definition for the suspend action.  I'll update the rest of actions as suggested.

Comment 3 Pawel Piech

2011-10-19 16:47:32 EDT

I fixed the key bindings for all actions in toolbar: http://git.eclipse.org/c/platform/eclipse.platform.debug.git/commit/?id=32e85a04193f7df1307c13eec1b647654bb26cef

In doing so, I also removed a piece of glue code in DebugCommandActionDelegate which was needed to show the tooltip when we had the toolbar actions contributed using a separate action set.

Mike, please take a look when you have a chance.

Comment 4 Michael Rennie

2011-10-24 12:00:51 EDT

(In reply to comment #3) 
> Mike, please take a look when you have a chance.

Noticed a few things:

1. the icons for the debug command actions do not show up in the keys pref page - not sure if this is some debug can fix or not.

2. the keybinding for terminate/resume/step* does not show in the tooltip until you start debugging - I would expect it to show always

Comment 5 Remy Suen

2011-10-24 14:44:20 EDT

(In reply to comment #4)
> 1. the icons for the debug command actions do not show up in the keys pref page
> - not sure if this is some debug can fix or not.

I think this is because the commands don't define an image.

> 2. the keybinding for terminate/resume/step* does not show in the tooltip until
> you start debugging - I would expect it to show always

I also see this. I guess this isn't really a bug with Eclipse 4 then, see bug 361528.

Comment 6 Michael Rennie

2011-10-25 15:38:46 EDT

(In reply to comment #5)
> I think this is because the commands don't define an image.

I opened bug 361997 for this.

Comment 7 Dani Megert

2011-10-26 02:05:10 EDT

Verified in I20111025-1800.