Bugzilla – Full Text Bug Listing
| Summary: | [patch] "Select All" is missing from "Edit Software site" dialog in target definition | ||
|---|---|---|---|
| Product: | [Eclipse Project] PDE | Reporter: | Tobias Bertelsen <tobiasbertelsen> |
| Component: | UI | Assignee: | pragya gaur <pragya.g> |
| Status: | VERIFIED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | alokmishra.besu, curtis.windatt.public, kai, mike, pragya.g, Vikas.Chandra |
| Version: | 4.2 | Keywords: | helpwanted |
| Target Milestone: | 4.5 M6 | ||
| Hardware: | PC | ||
| OS: | Windows 7 | ||
| Whiteboard: | |||
| Attachments: | |||
|
Description
Tobias Bertelsen
Yes, they are missing and should probably be added. It's probably not very difficult to copy the buttons (the UI reuses as much of the p2 components as possible). I don't have time for this at the moment, so I will mark it as help wanted. +1 for this... sorry to rant, but that UI *really* is a pain and could use a bit of love. Add All, but ideally it would be great if the "Edit Software site" UI looked and worked like one is familiar with from a PDE Launch Configuration Plug-ins tab, with Select/Deselect All and also an [X] Only show selected option, and if possible an Add Required and Validate. Created attachment 246239 [details]
Added Select All and DeSelect All buttons in "Edit Software Site" dialog in target definition
Hi Vikas, Please review my submission... Planning to review this in 4.5M5 Created attachment 250533 [details]
Last patch in sync with master code
I have put the last patch in sync with master code.
There are few issues with this patch 1) When you do select all, xyz items selected. The part selected is not fully visible 2) Deselect all doesnt give default 0 item selected 3) There is a TODO block in the code. Is that part of code taken from somewhere else in eclipse. 4) There is a deprecated api use. Are there no other options? I do not get what you mean by: 1) When you do select all, xyz items selected. The part selected is not fully visible Do you mean that the selected tree items should be expanded?? Also I will add default 0 selected. And I have taken this code from Install new Software available under Help toolbar item. I am looking into finding another API for achieving this functionality since its deprecated. It shows "10 items selec" instead of "10 items selected". The rest of the text is hidden. Created attachment 250620 [details]
Have done the necessary changes. Please review it.
Changed patch to be in sync with master, Added license year, changed access type of some functions for consistency Fixed with http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=5e403d52449492c6b9613ae36a446447ce6a280b Pragya, 1) Please put a patch which is with respect to latest code 2) Change license year to 2015 Looks like a minimal risk change. Tested this to be working fine and now this is in sync with Available Software dialog. Created attachment 251554 [details]
Last patch aligned with master code
Verified in Version: Mars (4.5) Build id: N20150315-1630 |