Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 361405

Summary:	Create Patch... dialog should not set file location
Product:	[Technology] EGit	Reporter:	Dani Megert <daniel_megert>
Component:	UI	Assignee:	Dani Megert <daniel_megert>
Status:	VERIFIED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	daniel_megert, markus.kell.r, matthias.sohn, remy.suen
Version:	1.2
Target Milestone:	---
Hardware:	All
OS:	All
Whiteboard:

Description Dani Megert

2011-10-19 10:12:37 EDT

The Create Patch... dialog should not set file location.

This is a pain since I want to put the patches into a specific folder but each time I want to create a patch it points again to a different folder.

Comment 1 Dani Megert

2011-10-19 10:13:13 EDT

To be more precise: it can set the file location but use the previous value and not some hard-coded path.

Comment 2 Remy Suen

2011-10-20 13:48:54 EDT

This annoys me as well.

Comment 3 Dani Megert

2011-11-01 12:26:42 EDT

http://egit.eclipse.org/r/4453 pushed for review.

Comment 4 Matthias Sohn

2011-11-03 07:09:06 EDT

merged as c68ec77bde3d770a20ca7ebd0d8e3963b03b2f0c

Comment 5 Remy Suen

2011-11-03 07:46:24 EDT

(In reply to comment #3)
> http://egit.eclipse.org/r/4453 pushed for review.

This change set appears to have broken the build. The build verifies our 3.6 compatibility by building against 3.6.2. It seems that a 3.7 API was used to fix this bug.

[ERROR] Failed to execute goal org.eclipse.tycho:tycho-compiler-plugin:0.12.0:compile (default-compile) on project org.eclipse.egit.ui: Compilation failure: Compilation failure:
[ERROR] <https://hudson.eclipse.org/hudson/job/egit/ws/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/GitCreatePatchWizard.java> (at line 106):[-1,-1]
[ERROR] setDialogSettings(DialogSettings.getOrCreateSection(Activator.getDefault().getDialogSettings(), "GitCreatePatchWizard")); //$NON-NLS-1$
[ERROR] ^^^^^^^^^^^^^^^^^^
[ERROR] The method getOrCreateSection(IDialogSettings, String) is undefined for the type DialogSettings
[ERROR] -> [Help 1]

Comment 6 Dani Megert

2011-11-03 07:57:00 EDT

(In reply to comment #5)
> (In reply to comment #3)
> > http://egit.eclipse.org/r/4453 pushed for review.
> 
> This change set appears to have broken the build. The build verifies our 3.6
> compatibility by building against 3.6.2. It seems that a 3.7 API was used to
> fix this bug.

Yep. Why did the first Hudson test run result in +1?

I saw that in http://wiki.eclipse.org/EGit/Contributor_Guide it says:
> Eclipse Platform 3.5 as minimum requirements
I thought this is a typo. Is it really targeting 3.5?

I can attach a new patch once it's clear whether 3.5, 3.6, 3.6.1 or 3.6.2 is the target.

Comment 7 Remy Suen

2011-11-03 08:04:20 EDT

(In reply to comment #6)
> Yep. Why did the first Hudson test run result in +1?

I am also curious about this. Perhaps we need a new bug to investigate this.

> I saw that in http://wiki.eclipse.org/EGit/Contributor_Guide it says:
> > Eclipse Platform 3.5 as minimum requirements
> I thought this is a typo. Is it really targeting 3.5?

It is open for discussion right now though that is what we have down at the moment.
http://wiki.eclipse.org/EGit/FAQ#What_versions_of_Eclipse_does_EGit_target.3F

Comment 8 Dani Megert

2011-11-03 08:26:52 EDT

Pushed http://egit.eclipse.org/r/4534 which fixes the incompatibility.

Comment 9 Matthias Sohn

2011-11-03 14:06:06 EDT

merged as 2112f56b0a6968e25100c20401047ac1496ec2ae

Comment 10 Dani Megert

2011-11-07 07:09:59 EST

Verified in 201111061513.