Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 361225

Summary: Selecting checkbox cell editor with space does not work in Chrome
Product: [RT] RAP Reporter: Ivan Furnadjiev <ivan>
Component: RWTAssignee: Project Inbox <rap-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 Flags: ivan: review? (tbuschto)
Version: 1.5   
Target Milestone: 1.5 M3   
Hardware: PC   
OS: Windows 7   
Whiteboard:
Attachments:
Description Flags
Proposed patch ivan: review?, tbuschto: review+

Description Ivan Furnadjiev CLA 2011-10-18 05:05:51 EDT 
Reproducible with Controls Demo -> TableViewer Tab in all browsers but Firefox.
1. Activate cell editors.
2. Click on a cell in the first column to activate the cell editor
3. Use TAB key to activate the CheckBox cell editor on the last column
4. Try to switch the checkbox selection with SPACE.
In Firefox it's working fine. In Chrome, IE and Safari you have to press enter first in order to make SPACE selection works again.
Comment 1 Ivan Furnadjiev CLA 2011-10-19 02:49:54 EDT 
Created attachment 205476 [details]
Proposed patch

This patch moves the _cancelEvent reset in the begining of SyncKeyEventUtil.js#intercept method to ensure clear state for every event. Remove browser switch (for IE) from KeyEventUtil.js#_isRelevantEvent.
Comment 2 Ivan Furnadjiev CLA 2011-10-19 02:51:59 EDT 
Tim, please review the patch.
Comment 3 Tim Buschtoens CLA 2011-10-19 05:24:18 EDT 
Comment on attachment 205476 [details]
Proposed patch

The ie-switch is something that pre-dates the EventHandler.js refactorings and should therefore not be necessary, but its unclear what exactly it was supposed to do in the first place. Therefore i'm unsure of this part. Everything else is fine.
Comment 4 Ivan Furnadjiev CLA 2011-10-19 06:36:12 EDT 
(In reply to comment #3)
> The ie-switch is something that pre-dates the EventHandler.js refactorings and
> should therefore not be necessary, but its unclear what exactly it was supposed
> to do in the first place. Therefore i'm unsure of this part. 
I also think that this ie-switch is not needed anymore after the EventHandler.js refactorings (I don't remember why it was introduced either). Applied patch to CVS HEAD and TTM branch.