Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 361218

Summary:	deprecate the ParseTreeConstructor
Product:	[Modeling] TMF	Reporter:	Moritz Eysholdt <moritz.eysholdt>
Component:	Xtext	Assignee:	Project Inbox <tmf.xtext-inbox>
Status:	NEW ---	QA Contact:
Severity:	normal
Priority:	P3	CC:	sebastian.zarnekow, st.oehme, sven.efftinge
Version:	2.1.0	Flags:	sebastian.zarnekow: juno+
Target Milestone:	---
Hardware:	PC
OS:	Mac OS X - Carbon (unsup.)
Whiteboard:
Bug Depends on:	463773
Bug Blocks:	439488

Description Moritz Eysholdt

2011-10-18 04:39:34 EDT

The new serializer outperforms the ParseTreeConstrucor in all disciplines. It's time to deprecate it. I suggest to mark the classes in org.eclipse.xtext.parsetree.reconstr as deprecated and move them to a different source folder, as we did it with the packrat parser.

Comment 1 Sebastian Zarnekow

2011-10-18 04:41:53 EDT

We should definitly do that for Juno!

Comment 2 Moritz Eysholdt

2011-10-18 04:45:12 EDT

(In reply to comment #1)
> We should definitely do that for Juno!

agreed.

Comment 3 Moritz Eysholdt

2014-05-19 10:13:11 EDT

I've marked

org/eclipse/xtext/parsetree/reconstr/Serializer.java and
org/eclipse/xtext/generator/parseTreeConstructor/ParseTreeConstructorFragment.java

as deprecated in 

http://git.eclipse.org/c/tmf/org.eclipse.xtext.git/commit/?id=e144e6e34b34885d2f41945efe57970aff3585a3

for the 2.6.0-release.

I'll leave this bug open to make sure we mark all other classes of the old serializer as deprecated and move them to a separate source folder.

It's very unfortunate that the default binding of ISerializer points to the old serializer. We need to discuss under which circumstances we can change that to the new serializer.

Comment 4 Stefan Oehme

2014-08-21 04:30:09 EDT

Some types from the old serializer package are used in other locations. This includes the IHiddenTokenHelper and the NodeIterator. So it's not as simple as putting @Deprecated everywhere.

Comment 5 Moritz Eysholdt

2016-07-21 05:30:46 EDT

Some tests for the PTC have been deleted due to
https://github.com/eclipse/xtext-core/issues/32