Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 361165

Summary:

Ugly "FORMOpenIdUser" title on sign in popup

Product:

[ECD] Orion

Reporter:

John Arthorne <john.arthorne>

Component:

Client

Assignee:

Malgorzata Janczarska <malgorzata.tomczyk>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

malgorzata.tomczyk, Szymon.Brandys

Version:

unspecified

Keywords:

polish

Target Milestone:

0.4 M1

Hardware:

OS:

Windows 7

Whiteboard:

Attachments:

Description	Flags
Screen shot	none

Description John Arthorne

2011-10-17 12:50:37 EDT

0.3 RC2

If I am not logged in on orion.eclipse.org, I get a popup that says "FORMOpenIdUser". This looks like some internal field name that is being leaked to the UI. After I login, this says "Orion workspace user", which is much better. Is there any way we can say the same thing before login? Best case scenario is that this would tell me what *domain* is trying to login (since the plugin requesting authentication might be on a different domain than my current browser page).

Comment 1 John Arthorne

2011-10-17 12:51:24 EDT

Created attachment 205350 [details]
Screen shot

Comment 2 Malgorzata Janczarska

2011-10-18 07:56:54 EDT

This is how it works:
All human-readable information is provided in the authentication plugin. They are rendered in the top right popup even if no 401 error was returned. When 401 is returned it contains minimum information: login form link and an ID of authentication that is used, for instance, to match what came from authentication plugin, to prompt you with all the human-readable information. But authentication plugin is not mandatory and if we don't have it we display what we've got.
What happened in your situation is probably that when 401 was thrown the authentication plugin wasn't deployed yet. I remember that we used to do a request to preference service before installing all the plugins. This may be it.
I'll double check whether it's possible that this prompt was displayed even if authentication plugin was installed. The other thing is that I can change "FORMOpenIdUser" for the domain, as long as we have a login form link.

Comment 3 Malgorzata Janczarska

2011-11-10 08:09:45 EST

I added a domain information to those authentication services that supply a login form. I also added a human-readable label to authentication error, so that even if there is no authenticationPlugin deployed something readable will be displayed. It's not mandatory.
You can verify if this is sufficient.