Bugzilla – Full Text Bug Listing
| Summary: | support scrolling and focus in review comment part | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | z_Archived | Reporter: | Robert Munteanu <robert.munteanu> | ||||||||
| Component: | Mylyn | Assignee: | Steffen Pingel <steffen.pingel> | ||||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||||
| Severity: | enhancement | ||||||||||
| Priority: | P3 | Keywords: | helpwanted | ||||||||
| Version: | 0.8 | ||||||||||
| Target Milestone: | 0.9 | ||||||||||
| Hardware: | PC | ||||||||||
| OS: | Linux | ||||||||||
| Whiteboard: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
Robert Munteanu
Created attachment 205334 [details]
Comments cut off
The fifth comment is cut off and there are a total of 7 comments for that topic. In this installation, the standard tooltips used by e.g. JDT work as expected.
That is indeed a problem. Can you suggest a solution? I think that behaving the way the JDT widgets behave would be perfect: * have a predefined size - the current width is fine, the height needs to be fixed * enable scrolling if the content height is larger that the defined widget size * have true focus when pressing F2 Thanks! Please let me know if you are interested in working on this. I would be interested, but on the other hand I have no idea how to approach this - any pointers would be useful. Looking at CommentPopupDialog comment parts appear to be embedded in a scrolledComposite already. Maybe it's just a matter of setting the proper size hints. There is similar code in SectionComposite that is used in search pages and has working scrolling support. It could be worth taking a look at as an example. I hope that helps a little bit. Created attachment 205519 [details]
mylyn/context/zip
Thanks, I'll see what I can do. Created attachment 205532 [details]
Draft patch
I've set up this patch, which allows scrolling ; focusing is still problematic. On both 3.5 and 3.7 target platforms I am able to focus, given that I wait for a couple of seconds with the mouse over the 'review' annotation and them move the mouse over the dialog.
I _think_ that the root cause is that the @CommentInformationControl.setFocus@ method is never called, therefore the CommentPopupDialog is never focused, which leads to the size not being recomputed. This patch takes us closer to having proper focus + scrolling, but I'd like to find out why setFocus was never called in the first place.
I'm not sure exactly how to debug this. Steffen, any ideas?
I'll try to find some time at the end of the week to look into this further. I am not sure what else is needed to make the focusing work. Would it be acceptable to target this localised fix for 3.6.3 and leave the issue open for a proper fix in 3.7 ? It would be an advantage to be able to have scrolling , as comments are right now simply cut off with no indicator that there is more information. (In reply to comment #11) > Would it be acceptable to target this localised fix for 3.6.3 and leave the > issue open for a proper fix in 3.7 ? It would be an advantage to be able to have > scrolling , as comments are right now simply cut off with no indicator that > there is more information. Sure, we can try. I can't promise that I'll have time to get to it though since we have scheduled 3.6.3 for mid next week already. (In reply to comment #12) > (In reply to comment #11) > > Would it be acceptable to target this localised fix for 3.6.3 and leave the > > issue open for a proper fix in 3.7 ? It would be an advantage to be able to > have > > scrolling , as comments are right now simply cut off with no indicator that > > there is more information. > > Sure, we can try. I can't promise that I'll have time to get to it though since > we have scheduled 3.6.3 for mid next week already. Thanks, that sounds reasonable. I'll do some more tests by Monday on non-Linux platforms too see if this patch introduces any inconsistencies. Applying the fix on top of e_3_7_m_3_6_x does not enable scrolling on Windows 7 . At least I can confirm that the same problems as on Linux/GTK appear. I suggest holding off this patch until we have a better fix. Moving to 0.9 backlog since that release is planned shortly after the maintenance release. That will give us a little bit more time to implement this. I have committed 8131afb54cc52320662111ac9eb45b86d8ea4f00 to fix the scroll bar. I didn't find a fix for focusing and hence have removed the Focus label for now. We'll need to revisit that later. |