Bugzilla – Full Text Bug Listing
| Summary: | [quick fix] Save actions are disabled after using Java quick fix in Java Editor | ||
|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Vitaliy Yakovchuk <Vitaliy.Yakovchuk> |
| Component: | UI | Assignee: | Platform UI Triaged <platform-ui-triaged> |
| Status: | CLOSED WONTFIX | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | daniel_megert, deepakazad, jeffreybolle, lukas.glowania, markus.kell.r, nickh186, pwebster, raksha.vasisht, robertkrikke, smikkelsen, stephan.herrmann, tarik.ozkanli, uschkinredsunshine, vkhomyackov |
| Version: | 3.7 | ||
| Target Milestone: | --- | ||
| Hardware: | PC | ||
| OS: | Linux | ||
| Whiteboard: | stalebug | ||
Cannot reproduce on 3.8 with I20111018-0850 build on Ubuntu 9.10. I could however reproduce it on ubuntu 11.04 with an earlier build - I20110912. Seems like it got fixed in 3.8. Pls try the latest build from 3.8 stream. Closing it as WORKSFORME. (In reply to comment #1) > Cannot reproduce on 3.8 with I20111018-0850 build on Ubuntu 9.10. Nope, sorry. Only worked once. Now I see the problem again. Reopening. Today I tried win32 version, everything works fine. (In reply to comment #2) > (In reply to comment #1) > > Cannot reproduce on 3.8 with I20111018-0850 build on Ubuntu 9.10. > Nope, sorry. Only worked once. Now I see the problem again. Reopening. Raksha, can you constantly reproduce it now? And on Windows 7? (In reply to comment #4) > (In reply to comment #2) > > (In reply to comment #1) > > > Cannot reproduce on 3.8 with I20111018-0850 build on Ubuntu 9.10. > > Nope, sorry. Only worked once. Now I see the problem again. Reopening. > > Raksha, can you constantly reproduce it now? And on Windows 7? Yes, it works fine on windows 7, but I see the problem on Linux- ubuntu 9.10 constantly on I20111018-0850. Also, the same quick fix works fine inside the same CU. *** Bug 360660 has been marked as a duplicate of this bug. *** *** Bug 358358 has been marked as a duplicate of this bug. *** *** Bug 350371 has been marked as a duplicate of this bug. *** *** Bug 363591 has been marked as a duplicate of this bug. *** This might be the same as one of the issue I observed while working on the quickfixes for null annotations. See bug 337977 comment 4. In may case, however, it sufficed to switch editors back and forth to be able to save again. And yes, I'm on ubuntu, too. (In reply to comment #10) > In may case, however, it sufficed to switch editors back and forth > to be able to save again. I can confirm that switching to other editor and back again enables save buttons. > And yes, I'm on ubuntu, too. Linux Mint 9 (Ubuntu 10.04 clone). Tried this today on 3 Linux machines but could not reproduce. Looks like I need to find an Ubuntu machine... *** Bug 370093 has been marked as a duplicate of this bug. *** (In reply to comment #12) > Tried this today on 3 Linux machines but could not reproduce. Looks like I need > to find an Ubuntu machine... One of these machines was Ubuntu 11.04. Stephan, which Ubuntu version are you using? Does the bug still happen with the latest Eclipse SDK builds? On fresh files i can do the quick fix 1 time without this bug coming up. When i delete the generated method and use the reappeared quick fix again, the bug is there. I retried several combinations of Kubuntu 11.04 vs. 11.10 and Eclipse SDK 4.2M5 vs. 3.8M5. Only one combination exhibits the bug: 11.10 & 3.8M5. Hmm... As for me, it looks like, It always happens if all files were saved befor using the quick fix. In the vast majority of cases when the bug comes up, a quick fix was used that switches the content of the editor ("generate method", "add exception to").
Today i saw the bug in action by just using the "add cast to" quick fix without switching of editor content.
I can reliably reproduce on Ubuntu 11.10 with latest builds, e.g. N20120216-2000. Important to reproduce: - B.java is open in an editor and in saved state - Quick Fix is executed by clicking into the Quick Fix hover or double-clicking the popup list (not applied via Enter key) The problem is that e.g. org.eclipse.ui.internal.handlers.SaveHandler#evaluate(IEvaluationContext) uses InternalHandlerUtil.getActiveWorkbenchWindow(context), but on this platform, the "activeWorkbenchWindow" variable is still null at this point because the focus is still in the Quick Fix hover or popup list's shell. WorkbenchSourceProvider#updateActiveShell(Map) should update "activeWorkbenchWindow", but it's too late since the SWT.Activate event is sent later on GTK. However, I think the check for the activeWorkbenchWindow doesn't make sense anyway and should be removed. I could also imagine other legitimate use cases where an editor could become dirty while the workbench window is not active. In that case the Save action should also be updated. The fixes in SaveHandler and SaveAsHandler are trivial (remove the call to "InternalHandlerUtil.getActiveWorkbenchWindow(context)"). The SaveAllHandler is harder, since the current workbench window is really used there. Maybe we need a "wokbenchWindow" variable that is not cleared when the shell loses focus? This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug. If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant. -- The automated Eclipse Genie. |
Build Identifier: 20110916-0149 Save, Save As and even Save All actions became not available after using Content Assist for creation a new method in other file (). Hot keys Ctrl+S, Ctrl+Shift+S do not work as well. The only way to save a file is to close Java Editor view and answer Yes in Save Resource dialog. Bug was present in Eclipse 3.7 and was not fixed in the latest update. Reproducible: Always Steps to Reproduce: 1. Create new public class A 2. Create new public class B in another file 3. Create a new method in class A (for example doIt()) 4. Create a new call in the doIt method to a some not existing method in class B, for example create method in class A: public void doIt(){ new B().newMethod(); } 5. Move cursor on not existing "newMethod" in shown Content Assistant's window click on "Create method "newMethod" in type B" or do the same by clicking on error in code icon. 6. When file B.java will be opened/activated, a "newMethod" will be created, but Save, Save As and Save All actions will disabled.