Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 361127

Summary:

AbstractActivityManager does not manage listeners properly

Product:

[Eclipse Project] Platform

Reporter:

Dean Roberts <dean.t.roberts>

Component:

Assignee:

Dean Roberts <dean.t.roberts>

Status:

VERIFIED FIXED

QA Contact:

Remy Suen <remy.suen>

Severity:

normal

Priority:

CC:

remy.suen

Version:

3.8

Target Milestone:

3.8 M3

Hardware:

All

OS:

All

Whiteboard:

Attachments:

Description	Flags
Patch	none

Description Dean Roberts

2011-10-17 08:35:51 EDT

AbstractActivityManager uses an ArrayList to manage its listeners.

The result is that if listeners are removed by a listener handler, then not all registered listeners will receive event notification.

The fix is simply to use ListenerList to store the list of Listeners and not ArrayList.

This problem (and fix) is similar and related to bug 359887.

Comment 1 Dean Roberts

2011-10-17 10:15:12 EDT

Created attachment 205332 [details]
Patch

Comment 2 Dean Roberts

2011-10-17 10:16:53 EDT

I think this patch should probably be back ported to the 3.x stream.  I have confirmed that listeners are being removed by the event handler.

Comment 3 Remy Suen

2011-10-17 13:18:55 EDT

(In reply to comment #1)
> Created attachment 205332 [details]
> Patch

Patch pushed to R3_development and R4_development. Thanks, Dean!

http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?h=R3_development&id=9b7ac33c63cbbb8911e1c318959067ebfe71ef84
http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?h=R4_development&id=9f8dc9cf07e6066ef6570e8b4afbefac494da803