Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 361051

Summary:

Single Text/Combo shows multiline text in WebKit browsers under some constellation

Product:

[RT] RAP

Reporter:

Ivan Furnadjiev <ivan>

Component:

RWT

Assignee:

Project Inbox <rap-inbox>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

tbuschto

Version:

1.4

Target Milestone:

1.5 M3

Hardware:

All

OS:

All

Whiteboard:

Attachments:

Description	Flags
possible fix	none
proposed fix	none
refised fix	none

Description Ivan Furnadjiev

2011-10-15 09:03:56 EDT

Reproducible with Controls Demo -> TableViewer Tab and cell editors activated in latest Chrome and Safari:
1. Navigate to a cell in the first table column and press ENTER to activate the cell editor.
2. Edit the cell and apply the value by pressing ENTER again.
3. Press ENTER again to activate the same cell editor - text field contains multiline text ???!!!
Probably a bug in WebKit, but we have to find a workaround.

Comment 1 Tim Buschtoens

2011-10-28 06:20:39 EDT

Created attachment 206123 [details]
possible fix

Ivan, please check if you think this always results in correct behavior when activating text cell editors.

Comment 2 Ivan Furnadjiev

2011-10-28 06:31:02 EDT

(In reply to comment #1)
> Ivan, please check if you think this always results in correct behavior when
> activating text cell editors.
With the proposed fix applied the problem is still there for me. Controls Demo -> TableViewerTab. Tested with Chrome 15.0.874.102. In Safari 5.1.1 there is no multiline, but the initial text in the field is deleted in some cases by the ENTER key.

Comment 3 Tim Buschtoens

2011-10-28 07:05:54 EDT

It seemed to work for me initially, but now i have the same issue with the empty field.

Comment 4 Tim Buschtoens

2011-10-28 08:14:50 EDT

Created attachment 206125 [details]
proposed fix

I think this works fine.

Comment 5 Ivan Furnadjiev

2011-10-28 08:22:11 EDT

(In reply to comment #4)
> Created attachment 206125 [details]
> proposed fix
> 
> I think this works fine.
With this patch the multiline issue with the Text cell editor is fixed. Unfortunately, Combo cell editor (TableViewer second column) still experiencing the same issue.

Comment 6 Tim Buschtoens

2011-10-28 10:17:43 EDT

Created attachment 206134 [details]
refised fix

The Combo "steals" the focus from Text on the widget level, but still gives it on the DOM level. Therefore the qx key event never gets to the text and the fix cant kick in. Fixed by adding a prevent default to Combo.js key handler.

Comment 7 Ivan Furnadjiev

2011-10-28 10:39:45 EDT

The latest patch is good for me - both Text and Combo. +1

Comment 8 Tim Buschtoens

2011-10-28 11:23:46 EDT

Applied patch 206134 to CVS HEAD.