Bugzilla – Full Text Bug Listing
| Summary: | remove styling code in javascript | ||
|---|---|---|---|
| Product: | [ECD] Orion | Reporter: | Susan McCourt <susan> |
| Component: | Client | Assignee: | Project Inbox <orion.client-inbox> |
| Status: | RESOLVED WONTFIX | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | libingw |
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Hardware: | PC | ||
| OS: | Windows 7 | ||
| Whiteboard: | |||
| Bug Depends on: | |||
| Bug Blocks: | 367970 | ||
we've done some of this in 0.3 when we are touching the code anyway. This bug is for a real pass to try to get rid of all of them. (In reply to comment #1) > we've done some of this in 0.3 when we are touching the code anyway. This bug > is for a real pass to try to get rid of all of them. In git-status-table.js , I still have something like : dojo.create("div", {style:"float: left;", align:"left"}, actionCol, "last"); Those were to create command span on top of the log zone and rebase zone. I was wondering if that piece of code should also use css style. If we should literally remove all code like "style:", that one should count. (In reply to comment #2) > (In reply to comment #1) > > we've done some of this in 0.3 when we are touching the code anyway. This bug > > is for a real pass to try to get rid of all of them. > > In git-status-table.js , I still have something like : dojo.create("div", > {style:"float: left;", align:"left"}, actionCol, "last"); > Those were to create command span on top of the log zone and rebase zone. > I was wondering if that piece of code should also use css style. > If we should literally remove all code like "style:", that one should count. that's a grey area as far as I'm concerned. There are places where we set things as hidden or display block, and to me that is fine, we are trying to toggle something on or off. The floats are kind of like that. At any rate I'm hoping to help you with command spans in bug 360986, so that there's a clear definition for where command spans like that belong, and at that point, assuming it's a common definition, we'd use a class. marking RC2 time and risk permitting. Lots of improvements have been made, but we haven't done an explicit global pass. We should at least see where we stand. Closing as part of a mass clean up of inactive bugs. Please reopen if this problem still occurs or is relevant to you. For more details see: https://dev.eclipse.org/mhonarc/lists/orion-dev/msg03444.html Closing as part of a mass clean up of inactive bugs. Please reopen if this problem still occurs or is relevant to you. For more details see: https://dev.eclipse.org/mhonarc/lists/orion-dev/msg03444.html |
We still have code, particularly in our various navigators, that style things while creating nodes. Example: } else if (item.Type === "Tag"){ col = document.createElement('td'); div = dojo.create("div", {style: "margin-left: 10px"}, col, "only"); These navigator margins need to be in CSS. We should search js files for "style:"