Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 361017

Summary: [client] how to get updated branch info from git clones UI?
Product: [ECD] Orion Reporter: Susan McCourt <susan>
Component: GitAssignee: Malgorzata Janczarska <malgorzata.tomczyk>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: john.arthorne, malgorzata.tomczyk, tomasz.zarna
Version: unspecified   
Target Milestone: 0.3 RC3   
Hardware: PC   
OS: Windows 7   
Whiteboard:
Attachments:
Description Flags
screenshot comparing branches none

Description Susan McCourt CLA 2011-10-14 14:08:10 EDT
Created attachment 205227 [details]
screenshot comparing branches

I'm trying to review bug 360193 for Gosia.  I don't see the branch in the repositories UI.  If I go to browse our repo on eclipse.org, I can see the branch.  See screenshot.  I know that i need to fetch all the tag/branch info from the repo.  How do I do this from the Orion UI?
Comment 1 Susan McCourt CLA 2011-10-14 14:25:21 EDT
this seems to be a hole in our current functionality.  We have "push all" but not "fetch all."  I had to delete the clone and reclone it in order to get the new branches.
Comment 2 Susan McCourt CLA 2011-10-14 14:28:36 EDT
This is not a good solution for the end user because now my workspace is different, and I had to delete and reconfigure my self hosting sites, and my favorites were broken, etc. etc.
Comment 3 Tomasz Zarna CLA 2011-10-17 04:39:41 EDT
(In reply to comment #0)
> [...] i need to fetch all the tag/branch info
> from the repo.  How do I do this from the Orion UI?

Do "Fetch from the remote" on the remote node in the Repositories. The tree is not refreshed, so you won't see new branches right away (obviously, it's a bug), but when I reloaded the page and drilled down to org.eclipse.orion.clinet/Remotes/origin I was able to see the new branches.

(In reply to comment #1)
> We have "push all" but not "fetch all."

Push all is for pushing commits and tags at the same time. It's true that we don't have a fetch action that does the same, but it would be no use in this particular case. It's for downloading all tags even those that do not point to objects reachable from the branch heads.

(In reply to comment #2)
> I had to delete and reconfigure my self hosting sites, and my favorites were broken, etc. etc.

I'm sorry to hear that. Gosia, could you please double check if "Fetch from the remote" works for you (except for the reloading issue), so we can avoid this kind of situations in the future.
Comment 4 Malgorzata Janczarska CLA 2011-10-17 09:01:21 EDT
I verified the problem and "Fetch from the remote" works, but there is one bug in it: id doesn't refresh the repositories view, so what I had to do was to close the remote node and open it again.
Susan, can you verify if this would work for you?

Anyway this is a bug to correct, let's hope the only one.
Comment 5 Malgorzata Janczarska CLA 2011-10-17 10:22:04 EDT
(In reply to comment #4)
> Anyway this is a bug to correct, let's hope the only one.

I pushed a fix for this, so Susan if everything else works for you this bug can be closed.
Comment 6 Susan McCourt CLA 2011-10-17 22:56:07 EDT
(In reply to comment #5)
> (In reply to comment #4)
> > Anyway this is a bug to correct, let's hope the only one.
> 
> I pushed a fix for this, so Susan if everything else works for you this bug can
> be closed.

waiting for a build on orion.eclipse.org where I can verify this...
Comment 7 Susan McCourt CLA 2011-10-19 12:07:32 EDT
(In reply to comment #6)
 
> waiting for a build on orion.eclipse.org where I can verify this...

I was able to verify this yesterday while working with a new topic patch fixing a bug.  So this bug can be closed.

I think I was tripped up two things:
1 - the refresh bug that you fixed
2 - the fact that you have to go to the remote to do the fetch to get the tags.  I think I tried this, but am not sure.  

This second one is funny because if you think, of course the branches are children of the remote, so if you want to see if there are new children, you must fetch from the parent.  But in the context of just trying to find a branch without really "thinking" about our UI structure, i could not figure this out. I was trying fetches from all over the place, and after seeing "push all" I started to assume that this was just a functional limitation.

I really see this problem as an issue with our current tree structure for repos.  When we tackle bug 359621, we can work on this further.
Comment 8 Tomasz Zarna CLA 2011-10-20 04:12:43 EDT
(In reply to comment #7)
> [...] the branches are
> children of the remote, so if you want to see if there are new children, you
> must fetch from the parent.  But in the context of just trying to find a branch
> without really "thinking" about our UI structure, i could not figure this out.

Right, maybe a message at the bottom of the branch list similar to "Can't find the branch you're looking for? Try Fetch on the remote." would help?
Comment 9 Tomasz Zarna CLA 2011-10-20 04:13:24 EDT
(In reply to comment #7)
> I was able to verify this yesterday while working with a new topic patch fixing
> a bug.