Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 361013

Summary: [client] inconsistent terminology: "Remove" vs. "delete"
Product: [ECD] Orion Reporter: Susan McCourt <susan>
Component: GitAssignee: Tomasz Zarna <tomasz.zarna>
Status: RESOLVED FIXED QA Contact:
Severity: trivial    
Priority: P3 CC: simon_kaegi, susan
Version: 0.3Flags: susan: review+
simon_kaegi: review+
Target Milestone: 0.3 RC3   
Hardware: PC   
OS: Windows 7   
Whiteboard:
Attachments:
Description Flags
Fix v01
none
mylyn/context/zip
none
Fix v02 none

Description Susan McCourt CLA 2011-10-14 13:26:31 EDT
I was deleting some old branches from my local git repo and found myself doing a double take, because the familiar "Delete" icon from the navigator said "Remove."  We should use consistent terminology.
Comment 1 Tomasz Zarna CLA 2011-10-17 06:33:10 EDT
Created attachment 205305 [details]
Fix v01

(In reply to comment #0)
> We should use consistent terminology.

I totally agree. The patch replaces "remove" with "delete"... and "repository" with "clone" as the repo is something we clone to create a clone and we're on the Git Clones page.
Comment 2 Tomasz Zarna CLA 2011-10-17 06:33:12 EDT
Created attachment 205306 [details]
mylyn/context/zip
Comment 3 Susan McCourt CLA 2011-10-17 23:11:37 EDT
(In reply to comment #1)
> Created attachment 205305 [details]
> Fix v01
> 
> (In reply to comment #0)
> > We should use consistent terminology.
> 
> I totally agree. The patch replaces "remove" with "delete"... and "repository"
> with "clone" as the repo is something we clone to create a clone and we're on
> the Git Clones page.

Nitpicking, ...I don't agree with the change from "repository" to "clone."  You are correct that we are inconsistent, but...

- the link to this page in the banner is called "Repositories"
- in this page, you can clone a repository, but you can also create a new one that is not a clone of anything.

So wouldn't it make more sense to keep the "repository" terminology and perhaps rename the page from "Git Clones" to "Git Repositories"?
Comment 4 John Arthorne CLA 2011-10-18 11:06:22 EDT
Clone and repository are synonymous in Git.  Using a different term depending on whether it has a corresponding remote is too subtle.

We should pick one term and stick with it. I don't feel strongly but I would pick "Repository". The word "Clone" doesn't really describe what it is, but just that it is a copy of something. A clone could also mean a sheep or a tomato.

I agree on fixing up the inconsistency. I clicked on a link called "Repositories" and I arrived at a page called "Clones". They should be consistent.
Comment 5 Tomasz Zarna CLA 2011-10-18 12:30:24 EDT
Created attachment 205439 [details]
Fix v02

(In reply to comment #3 and comment #4)
> [...] keep the "repository" terminology and perhaps
> rename the page from "Git Clones" to "Git Repositories"?

Fine with me. Left "repositories" untouched and renamed "Git Clones" to "Git Repositories".
Comment 6 Tomasz Zarna CLA 2011-10-19 05:28:56 EDT
Fixed with 98f9ff7715b79cff7dd4efd9b51a65ee288f9c7d.