Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 361000

Summary:

Backport to 3.2.x [dstore] Hang during debug source look up

Product:

[Tools] Target Management

Reporter:

Samuel Wu <samuelwu>

Component:

RSE

Assignee:

David McKnight <dmcknigh>

Status:

RESOLVED FIXED

QA Contact:

Martin Oberhuber <mober.at+eclipse>

Severity:

normal

Priority:

CC:

dmcknigh, kjdoyle, xuanchen

Version:

unspecified

Flags:

kjdoyle: review+
xuanchen: review+

Target Milestone:

3.2.2+

Hardware:

OS:

Windows XP

Whiteboard:

Bug Depends on:

358301

Bug Blocks:

Attachments:

Description	Flags
backport patch	none
Dump from the DSTORE server	none
additional patch to deal with other out of memory cases	none
dstore server dumps	none
patch to handle additional cases	none

Description Samuel Wu

2011-10-14 12:11:36 EDT

Build Identifier: RSE 3.2 Maintenance

https://bugs.eclipse.org/bugs/show_bug.cgi?id=358301

Reproducible: Always

Steps to Reproduce:
We are not on RSE 3.4 yet. Please back port the fix to bug 358301 to RSE 3.2. Thanks a lot.

Comment 1 David McKnight

2011-10-14 13:57:07 EDT

Created attachment 205225 [details]
backport patch

Comment 2 David McKnight

2011-10-14 13:57:29 EDT

Kevin, could you please review this patch?

Comment 3 Kevin Doyle

2011-10-17 10:59:12 EDT

Minor change needed for the Sender class.  There is an additional "_xmlGenerator.flushData();
"  on the last line changed in it that isn't required.

Comment 4 David McKnight

2011-10-17 12:06:31 EDT

Thanks for the review, Kevin.  I took out the extra flushData() call and committed the change to the R3_2_maintenance stream.

Comment 5 Samuel Wu

2011-10-18 13:43:35 EDT

There were still uncaught memory exceptions. It hung again. The host dumps were attached.

Comment 6 Samuel Wu

2011-10-18 13:44:55 EDT

Created attachment 205445 [details]
Dump from the DSTORE server

The test was done with rseserver-M20111018-1100-linux.tar

Comment 7 David McKnight

2011-10-19 14:39:41 EDT

Created attachment 205557 [details]
additional patch to deal with other out of memory cases

Comment 8 David McKnight

2011-10-19 14:40:11 EDT

Xuan, could you please review the last patch?

Comment 9 Xuan Chen

2011-10-26 11:13:12 EDT

The patch looks good.  Thanks.

Comment 10 David McKnight

2011-10-26 11:27:10 EDT

Thanks for the review, Xuan.  I've committed the change to the R3_2_maintenance stream.

Comment 11 Samuel Wu

2011-11-01 17:31:57 EDT

Created attachment 206300 [details]
dstore server dumps

I picked up the driver built on 10/27 but still got the dump.

Comment 12 Samuel Wu

2011-11-01 17:34:15 EDT

Was the fix in the 10/27 build?

Comment 13 David McKnight

2011-11-01 18:05:14 EDT

(In reply to comment #11)
> Created attachment 206300 [details]
> dstore server dumps
> 
> I picked up the driver built on 10/27 but still got the dump.

These dumps look different from previous ones.  Each of these cases involve starting the FileQueryThread:

at java/lang/Thread.start(Thread.java:970)
at org/eclipse/rse/internal/dstore/universal/miners/filesystem  /FileQueryThread.doQueryAll(FileQueryThread.java:130)
at org/eclipse/rse/internal/dstore/universal/miners/filesystem/FileQueryThread.run(FileQueryThread.java:71)

For this case, I could override Thread.start() to catch the OutOfMemoryError.

Comment 14 David McKnight

2011-11-07 10:52:38 EST

Created attachment 206530 [details]
patch to handle additional cases

Comment 15 David McKnight

2011-11-07 10:56:32 EST

Xuan, could you review the latest patch for this?  It's just a couple additional cases.

Comment 16 Xuan Chen

2011-11-14 11:43:59 EST

The fix looks good.  Thanks.

Comment 17 David McKnight

2011-11-14 12:04:59 EST

Thanks for the review, Xuan.  I've committed the change to the R3_2_maintenance stream.