Bugzilla – Full Text Bug Listing
| Summary: | [favorites]Add more entries making favorites. | ||
|---|---|---|---|
| Product: | [ECD] Orion | Reporter: | libing wang <libingw> |
| Component: | Client | Assignee: | Project Inbox <orion.client-inbox> |
| Status: | RESOLVED WONTFIX | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | andrew.eisenberg, john.arthorne, mamacdon, simon_kaegi, susan |
| Version: | 0.3 | ||
| Target Milestone: | --- | ||
| Hardware: | PC | ||
| OS: | Windows 7 | ||
| Whiteboard: | |||
| Bug Depends on: | 361003, 369555 | ||
| Bug Blocks: | |||
|
Description
libing wang
I started to wonder recently if any navigator command that is scoped for a file should be available in the editor toolbar under some menu. Things like marking favorite are very simple, as are the link commands (git log on the file, etc.). Some of them (rename, move/copy) might require some additional work. (In reply to comment #1) > I started to wonder recently if any navigator command that is scoped for a file > should be available in the editor toolbar under some menu. Navigator commands are useful. Actually I just opened bug 360996. (In reply to comment #1) > I started to wonder recently if any navigator command that is scoped for a file > should be available in the editor toolbar under some menu. Things like marking > favorite are very simple, as are the link commands (git log on the file, etc.). > Some of them (rename, move/copy) might require some additional work. opened bug 361003 for this. *** Bug 368897 has been marked as a duplicate of this bug. *** keybinding suggestion in dup bug: Suggested keybinding: 'F' in navigator and 'ESC F' in editor (see Bug 366445 for discussion on keybindings). I added support for making the current page a favorite. See bug 368897. The other cases are not yet supported. The wiring is all in place, but I just ran out of time. (In reply to comment #0) > 1.In the file open dialog, if I find a file I would like to make it favorite > for using it repeatedly. I think we should probably contribute and render this command in the dialog. I originally imagined a more generic solution but I really do think we wouldn't want to crowd the open resource dialog with operations like "rename" etc. > 2.If I already opened a file but forgot to make favorite, I have to go back to > where I opened it and make favorite again. I should be able to make favorite in > the editor tool bar. (save search is good feature in the global search. We can > refer to it) Fixed this. see bug 368897 > 3.In the add favorite UI, it will be nice to search the file instead of type > the full name of the file. This is really intended for pasting in URLs. I think this use case is solved if you can search a file and favorite it (#1) > 4. In the search result page, I should be able to make favorite on a file, or, > make a group of files as favorites. Agree. So I think that given the current state of the code, this bug boils down to this: We should have an option in the common search rendering code that will render a make favorite command next to a file. It may end up looking bit odd in open resource to see: * file * foo -------- bar * baz * Where the star on the left means it is a favorite, and the star on the right means "make it a favorite." So this should probably be fixed along with 371007 moving milestone to 2.0 M1 for future triage. Closing as part of a mass clean up of inactive bugs. Please reopen if this problem still occurs or is relevant to you. For more details see: https://dev.eclipse.org/mhonarc/lists/orion-dev/msg03444.html |