Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 360977

Summary: Key board navigation in file open dialogue.
Product: [ECD] Orion Reporter: libing wang <libingw>
Component: ClientAssignee: Andrew Clement <aclement>
Status: RESOLVED FIXED QA Contact:
Severity: enhancement    
Priority: P3 CC: aclement, john.arthorne, mamacdon
Version: 0.3   
Target Milestone: 0.4 M2   
Hardware: PC   
OS: Windows 7   
Whiteboard:

Description libing wang CLA 2011-10-14 10:30:12 EDT 
Tested on 0.3RC2.
In Orion navigator, press "t". Or, in Orion editor, press "ctrl+shift+r", you will open the file search dialog. 
Type a key word, the dialog shows a list of files that match. Pressing "enter" will open the first file in the list. 
It will be nice if we can support key navigation in the dialog. 
A perfect work flow is :
1.Open the dialog.
2.Type the key word.
3.Use up and down key in the list.
4.Press enter and open that file.
Comment 1 John Arthorne CLA 2011-10-14 11:26:32 EDT 
Note you can use Tab to traverse through the list of matches. Up/Down arrows would be nicer I suppose.
Comment 2 Andrew Clement CLA 2012-01-24 11:55:31 EST 
Pull request to implement this feature:

https://github.com/eclipse/orion.client/pull/17

Given that tab navigation through results doesn't seem to work in some browsers (firefox), this seems quite  an important issue to address.

Note: For enter to correctly close the dialog when a selection is made the pull request attached to bug 344614 needs to be committed also.

 I wrote all this code and have the rights to contribute it to Eclipse under the eclipse.org web site terms of use.
Comment 3 Andrew Clement CLA 2012-01-25 11:12:18 EST 
Oops, I see you don't want pull requests at the moment.  All info in another way:

git repo: git://github.com/aclement/orion.client.git
branch: bug360977
commit id: 2f130011b2131007101b50de9c97b67549c5d1e3
full link:
https://github.com/aclement/orion.client/commit/2f130011b2131007101b50de9c97b67549c5d1e3

I wrote all this code and have the rights to contribute it to Eclipse under the
eclipse.org web site terms of use.
Comment 4 libing wang CLA 2012-01-26 11:58:36 EST 
(In reply to comment #3)
> Oops, I see you don't want pull requests at the moment.  All info in another
> way:
> 
> git repo: git://github.com/aclement/orion.client.git
> branch: bug360977
> commit id: 2f130011b2131007101b50de9c97b67549c5d1e3
> full link:
> https://github.com/aclement/orion.client/commit/2f130011b2131007101b50de9c97b67549c5d1e3
> 
> I wrote all this code and have the rights to contribute it to Eclipse under the
> eclipse.org web site terms of use.

Thanks, Andrew. I will look and push it today.
Comment 5 libing wang CLA 2012-01-26 13:47:35 EST 
(In reply to comment #3)
> Oops, I see you don't want pull requests at the moment.  All info in another
> way:
> 
> git repo: git://github.com/aclement/orion.client.git
> branch: bug360977
> commit id: 2f130011b2131007101b50de9c97b67549c5d1e3
> full link:
> https://github.com/aclement/orion.client/commit/2f130011b2131007101b50de9c97b67549c5d1e3
> 
> I wrote all this code and have the rights to contribute it to Eclipse under the
> eclipse.org web site terms of use.

Thanks, Andrew. I will look and push it today.
Comment 6 libing wang CLA 2012-01-26 13:49:06 EST 
Transferring to John as he will review all the code changes for openResourceDialog.js