Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 360956

Summary:	"Compare with Version in Ancestor" operation in Commit views sometimes a no-op
Product:	[Technology] EGit	Reporter:	R Shapiro <rshapiro>
Component:	Core	Assignee:	Kevin Sawicki <kevin>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	matthias.sohn, remy.suen
Version:	unspecified
Target Milestone:	---
Hardware:	All
OS:	All
Whiteboard:

Description R Shapiro

2011-10-14 08:33:41 EDT

The very handy "Compare with Version in Ancestor" operation in Commit view has a quirk in the following case:

1) Fetch changes

2) Open any fetched commit listed in the dialog by double-clicking the entry

3) Close the dialog

4) Right-click any file in the "Files" section and select "Compare with Version in Ancestor" from the popup menu

Expected: diff view for that file.
Observed: nothing happens - no diff, no error.

If you close the commit view and re-open it, for instance by double-clicking the entry the Reflog view, and then re-run step (4) above, a diff view appears as expected

As a side note, consider making the list of commits a non-modal view rather than a modal dialog so that each commit of any given fetch or pull can be examined in turn.

Comment 1 Kevin Sawicki

2011-10-14 11:42:31 EDT

Proposed fix pushed to: http://egit.eclipse.org/r/#change,4351

Comment 2 Matthias Sohn

2011-10-14 15:20:03 EDT

merged as bb114819c2580544a47988bf5ae1f5415cce866b