Bug 360908

Description Deepak Azad 2011-10-14 01:09:26 EDT

In the following snippet there is a 'Resource leak: 'reader' is never closed' warning. However, the underlying resource is closed explicitly so practically it is not an issue. Can we avoid these kinds of warnings? Do we want to - I mean is it a bad practice to close the underlying resource instead of the top level one?

--------------------------------------------------------------------
boolean load1(final URL url) throws IOException {
	InputStreamReader inputStreamReader = new InputStreamReader(url.openStream());
	try {
		final BufferedReader reader = new BufferedReader(inputStreamReader);                    //warning
		int ch;
		while ((ch = reader.read()) != -1) {
			System.out.println(ch);
		}
	} finally {
		try {
			if (inputStreamReader != null)
				inputStreamReader.close();
		} catch (IOException x) {
		}
	}
	return false;
}
--------------------------------------------------------------------

This is a simplified case of the following warning in o.e.jdt.ui -
Resource leak: 'reader' is never closed	AbstractSpellDictionary.java	/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/spelling/engine	line 626