Bugzilla – Full Text Bug Listing
| Summary: | Remove GtkCombo and friends. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Alexander Kurtakov <akurtakov> | ||||
| Component: | SWT | Assignee: | Alexander Kurtakov <akurtakov> | ||||
| Status: | RESOLVED FIXED | QA Contact: | Silenio Quarti <Silenio_Quarti> | ||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | arunkumar.thondapu, eclipse.felipe, sbasalaev | ||||
| Version: | 3.8 | ||||||
| Target Milestone: | 3.8 M4 | ||||||
| Hardware: | PC | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 340067, 361004 | ||||||
| Attachments: |
|
||||||
P.S. This patch reduces quite a number of deprecated issues for the gtk3 port. I haven't done any formating to keep the patch easy for review. Git repo available. Commit is http://fedorapeople.org/gitweb?p=akurtakov/public_git/eclipse.platform.swt.git;a=commit;h=cfb3d218516add50ab43691a4350dd0b3005cf67 Released patch to branch: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=f387cedab0a11fb8c290dcad92bd0503c5f0facb I opened bug#363956 to clean up Combo further given that there is still quite a bit of unused code in there after these changes and changes for bug#361004. Thanks Alexander. |
Created attachment 205145 [details] The patch. The attached patch is removing GtkCombo and related functions which are using only for pre gtk 2.4.0 which is unsupported by latest SWT. The patch looks way bigger than it is actually, thanks to jnigen changes which I decided to include in order to have proper git-formatted patch (appliable with git am). Build and tested locally without any problems seen (gtk 2.24)