Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 360857

Summary: org.eclipse.equinox.internal.p2.transport.ecf.FileReader silently swallows exceptions
Product: [Eclipse Project] Equinox Reporter: Steffen Pingel <steffen.pingel>
Component: p2Assignee: P2 Inbox <equinox.p2-inbox>
Status: CLOSED DUPLICATE QA Contact:
Severity: major    
Priority: P3 CC: matthew
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Linux   
Whiteboard:

Description Steffen Pingel CLA 2011-10-13 12:00:49 EDT 
If an invalid proxy is configured that results in null for the proxy host, FileReader.sendRetrieveRequest() silently swallows the IllegalArgumentException that is thrown by the constructor of HttpHost. The results is that calls to read() on the InputStream returned by FileReader.read() block forever. In the case of Mylyn this caused silent blocking of tests without any indication of an error (bug 360824).

It doesn't seem right that the code silently ignores Throwables:

...
			} catch (Throwable t) {
				if (exception != null)
					exception.printStackTrace();
			}
			if (checkException(uri, retryCount))
				break;

checkException simply returns true indicating that the connection request was sent.
Comment 1 Matthew Piggott CLA 2011-10-13 13:07:51 EDT 

*** This bug has been marked as a duplicate of bug 312069 ***