Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 360836

Summary: Utf8Appendable throws Exception where it before added replacement chars
Product: [RT] Jetty Reporter: Thomas Becker <tbecker>
Component: otherAssignee: Greg Wilkins <gregw>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: gregw
Version: unspecified   
Target Milestone: 7.5.x   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
proposed patch none

Description Thomas Becker CLA 2011-10-13 10:21:49 EDT
Build Identifier: 

We've discussed to roll back to replacing invalid UTF8 chars.

Reproducible: Always
Comment 1 Thomas Becker CLA 2011-10-13 10:25:13 EDT
Created attachment 205130 [details]
proposed patch
Comment 2 Greg Wilkins CLA 2011-10-19 00:14:46 EDT
Thanks Thomas. 

But don't forget to assign these issues to somebody to look at your patch.
Comment 3 Greg Wilkins CLA 2011-10-19 00:28:38 EDT
Thomas,

this was not how I asked for this to be fixed.

The Utf8Appendable should still throw the exception, but we should catch and ignore it instead. 

Without the thrown exception, we will not pass all the fast fail tests, which is why we changed the Utf8Appendable in the first place!
Comment 4 Greg Wilkins CLA 2011-10-19 01:32:32 EDT
Catch, log and then ignore the exception in decodeUtf8to