Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 360819

Summary:	[M2x IDE Integration] Issue with "Apply" and "OK" buttons in EcucOutletsPreferencePage
Product:	[Automotive] Sphinx	Reporter:	Ali AKAR <ali.akar82>
Component:	Core	Assignee:	Ali AKAR <ali.akar82>
Status:	CLOSED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	idydieng, stephaneberle9
Version:	0.7.0
Target Milestone:	0.7.0
Hardware:	PC
OS:	Mac OS X - Carbon (unsup.)
Whiteboard:

Description Ali AKAR

2011-10-13 09:31:12 EDT

In the properties of a project edited in EcucOutletsPreferencePage, if we add
an outlet, then click on "apply", and then click on "ok" to close the window,
the outlet is created twice, and generates an error next time the code
generator is executed.

Comment 1 Idrissa Dieng

2011-11-08 09:58:30 EST

(In reply to comment #0)
> In the properties of a project edited in EcucOutletsPreferencePage, if we add
> an outlet, then click on "apply", and then click on "ok" to close the window,
> the outlet is created twice, and generates an error next time the code
> generator is executed.

Hi Ali, I see you've already fixed this bug by introducing 'unappliedOutlets' list that keep unapplied outlets before store preference values.

I would made some minors changes and mark this bug as resoved:

* Use Set<ExtendedOutlet> allOutlets & Set<ExtendedOutlet> unappliedOutlets instead of List<ExtendedOutlet> in OutletProvider class;

* Change the implementation of  OutletProvider#getOutlets()like this

public Set<ExtendedOutlet> getOutlets() {
    return Collections.unmodifiableSet(allOutlets);
}

instead of 

public Collection<ExtendedOutlet> getOutlets() {
   return Collections.unmodifiableCollection(allOutlets);
}

Comment 2 Idrissa Dieng

2011-11-08 10:01:55 EST

fixed!

Comment 3 Balazs Grill

2021-07-14 02:14:30 EDT

Mass-closing Resolved tickets