Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 360811

Summary:	Rework ZK Preferences Synchronization
Product:	z_Archived	Reporter:	Gunnar Wagenknecht <gunnar>
Component:	gyrex	Assignee:	Gunnar Wagenknecht <gunnar>
Status:	RESOLVED FIXED	QA Contact:
Severity:	enhancement
Priority:	P3	CC:	andreas.mihm, mike.tschierschke
Version:	unspecified
Target Milestone:	---
Hardware:	All
OS:	All
Whiteboard:
Bug Depends on:	360505
Bug Blocks:	358210

Description Gunnar Wagenknecht

2011-10-13 08:59:52 EDT

Cloud preferences is implemented based on ZooKeeperBasedPreferences which is based on ZooKeeperBasedService. A disconnect and re-connect on a server with a fair amount of stuff saved in the preferences involves a lot of listeners as well as watches. ZooKeeperBasedService registers listeners with ZooKeeperGate. ZooKeeperBasedPreferences registers watches with ZooKeeper.

We might not be able to reduce the amount of watches in ZooKeeper. However, we should investigate using just one singleton watcher for preferences synchronization. It would receive all watch events and batches necessary model updates which would then be processed asynchronously. Updates for children could be combined into a single tree update (which often happens anyway). Thus, a watch event storm would not end up in double fresh events.

This work also needs to take DISCONNECT as well as SESSION_EXPIRED into account (bug 360505). Preferences may continue to work (except flush/sync) on DISCONNECT until SESSION_EXPIRED is triggered.

Comment 1 Gunnar Wagenknecht

2011-10-26 14:42:15 EDT

I committed a rework away from many listeners to a single client side watcher implementation. I did not implement that batching and asynchronous refresh of nodes. However, it's now far more easier to implement it later *if* we realize that this has some benefits we need.