Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 360745

Summary:	remove --symbol_map from linker.cmd (.xdl) files for TI/ELF targets
Product:	[Technology] RTSC	Reporter:	Karl Wechsler <karl>
Component:	Targets	Assignee:	Vikram Adiga <vikram.adiga>
Status:	CLOSED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	ademars, d-russo, dfriedland, sascha
Version:	unspecified
Target Milestone:	---
Hardware:	All
OS:	All
Whiteboard:	target:3.23.01

Description Karl Wechsler

2011-10-12 19:48:18 EDT

The --symbol_map is not needed for TI ELF compilers.   I tested with 7.3.0 for 674x and 4.9.0 for Stellaris and I see that the linker .cmd files are nearly identical for the stairstep app when build with this alias, and after I comment it out of the generated .cmd file.

I see 4 words difference when removing this --symbol_map.  For some reason, the System_vsprintf__E is not aliased to System_vprintf__F when this alias is removed.  All other aliases remain.

We need to continue to clean up the generated files.  And our overloaded use of --symbol_map which requires the cheeky --diag_remark=10268 causes problems when users enable full remarks with --issue_remarks.  

They see all of our internal issues along with remarks in their code that they are looking for.

Comment 1 Karl Wechsler

2011-10-12 19:50:18 EDT

One more thing ...

This is not needed since the TI ELF linkers now have a built-in "remove trivial trampolines" feature for the ELF link step.  If function is seen to have same signature as the function it calls, and there is no other code except simple function call, then the linker maps the 2 symbols to same code.

I believe this started with 7.1 or 7.2 for 6x.  And 4.9 for Arm.

Comment 2 Dave Russo

2011-11-29 14:23:28 EST

*** Bug 342090 has been marked as a duplicate of this bug. ***

Comment 3 Vikram Adiga

2012-01-17 20:48:51 EST

fixed. TI/ELF linker.cmd files no longer contains --symbol_map.

Comment 4 Vikram Adiga

2012-01-18 17:16:35 EST

fix to be part of next target release (xdctargets-f14)

Comment 5 Vikram Adiga

2012-01-24 14:33:07 EST

fix also includes changes in platform tree which will be released in platform-n10

Comment 6 Karl Wechsler

2012-02-07 20:07:02 EST

installed 3.23.01.29_eng and rebuild M3/ELF and 674/ELF.

Reviewed the generated .cmd files --> no more symbol_map stuff!  

Reviewed .map file and confirmed that linker is indeed folding the __E/__F to same symbol.

verify pass.

Comment 7 Dave Russo

2013-01-24 15:12:11 EST

xdctools 3.23.05 GA is available from here: http://www.sanb.design.ti.com/tisb_releases/XDCtools/3_23_05_61/