Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 360740

Summary: Potential memory leak within ScrollableThumbnail
Product: [Tools] GEF Reporter: Alexander Nyßen <nyssen>
Component: GEF-Legacy Draw2dAssignee: Alexander Nyßen <nyssen>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3    
Version: 3.7.1   
Target Milestone: 3.7.2 (Indigo SR2)   
Hardware: All   
OS: All   
Whiteboard:
Bug Depends on:    
Bug Blocks: 168799    

Description Alexander Nyßen CLA 2011-10-12 18:17:54 EDT 
The syncher and keyListener, which are registered on the selector figure during initialization, don't get unregistered upon deactivation. Up to now this does not seem to be harmful (as both are local instances that are not exposed), but leaving a clean state doesn't do any harm either, thereby preventing potential memory leaks that may be caused by changes in the future.
Comment 1 Alexander Nyßen CLA 2011-10-12 18:30:39 EDT 
Introduced private hookSelector(), unhookSelector(), hookViewport(), and unhookViewport() methods that get called during initialization and deactivation respectively. Changed SelectorFigure to no longer cache the image but only the underlying image data, so it no longer required a dispose().

Committed changes to cvs HEAD (3.8) as well as R_3_7_maintenance branch. Resolving as fixed in 3.7.2.