Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 360689

Summary:	Can not deactivate Link with Editor in outline
Product:	[Technology] DLTK	Reporter:	Simon Bernard <sbernard>
Component:	Common	Assignee:	dltk.common-inbox <dltk.common-inbox>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	alex.panchenko, contact, st.mailinglists
Version:	3.0
Target Milestone:	5.0
Hardware:	PC
OS:	Windows XP
Whiteboard:

Description Simon Bernard

2011-10-12 12:02:22 EDT

When I uncheck the "Link With Editor" Action in the outline, Editor and outline is  still linked.

I test it with ruby editor and tcl editor with eclipse indigo.

I have a look to the code and I see that the "ToggleLinkingAction" modifies the PreferenceConstants.EDITOR_SYNC_OUTLINE_ON_CURSOR_MOVE in the DLTKUI preference store.
see : org.eclipse.dltk.internal.ui.editor.ScriptOutlinePage.ToggleLinkingAction.run()

Editor checks the same preference but not in the same preference store. it checks in its composite store which does not contain the DLTKUI preference store.
see : org.eclipse.dltk.internal.ui.editor.ScriptEditor.createCombinedPreferenceStore(IEditorInput)


I suppose DLTKUI preference store should be add to the editor composite store or the ToggleLinkingAction should use the outline preference which is the same that the ScriptEditor.

Futhermore, I thought the EDITOR_SYNC_OUTLINE_ON_CURSOR_MOVE default value should be true.

Comment 1 Stefan Thurnherr

2012-09-04 11:12:47 EDT

This bug is still present in Eclipse 4.2.0.

Use case is rare, but a few moments ago I was very happy to discover the "Link with Editor" menu item in the Outline view - and then got disappointed that it does not work.

Comment 2 Alex Panchenko

2012-09-27 02:02:57 EDT

Fixed

Comment 3 Stefan Thurnherr

2012-09-27 03:26:13 EDT

Great, thank you!

Whats the expected Eclipse release that corresponds to DLTK 5.0 (target milestone)?

Comment 4 Alex Panchenko

2012-09-27 03:58:21 EDT

DLTK 5.0 is going to be part of simultaneous Kepler release in June 2013.
The fix will be in the nearest milestone builds - not sure if it's enough time for M2, but M3 for sure.