Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 360551

Summary: [ui] Invalid Thread Access SWTException in ProvisioningOperationRunner.requestRestart
Product: [Eclipse Project] Equinox Reporter: Justin Dolezy <justin>
Component: p2Assignee: P2 Inbox <equinox.p2-inbox>
Status: RESOLVED WONTFIX QA Contact:
Severity: normal    
Priority: P3 CC: pascal, picard, remy.suen
Version: unspecified   
Target Milestone: ---   
Hardware: All   
OS: All   
Whiteboard: stalebug

Description Justin Dolezy CLA 2011-10-11 10:54:31 EDT
Build Identifier: 20110916-0149

Setting the restart policy to Policy.RESTART_POLICY_FORCE will cause the update operation to fail with an "Invalid Thread Access" SWTException.

ProvisioningOperationRunner is calling PlatformUI.getWorkbench().restart() from the job thread which causes the exception.

This is actually an old issue, see also: http://www.eclipse.org/forums/index.php/m/631924/


Stack Trace info:
=================

!ENTRY org.eclipse.ui.workbench 4 2 2011-10-11 15:32:45.927
!MESSAGE Problems occurred when invoking code from plug-in: "org.eclipse.ui.workbench".
!STACK 0
org.eclipse.swt.SWTException: Invalid thread access
	at org.eclipse.swt.SWT.error(SWT.java:4282)
	at org.eclipse.swt.SWT.error(SWT.java:4197)
	at org.eclipse.swt.SWT.error(SWT.java:4168)
	at org.eclipse.swt.widgets.Widget.error(Widget.java:774)
	at org.eclipse.swt.widgets.Widget.dispose(Widget.java:661)
	at org.eclipse.jface.window.Window.close(Window.java:335)
	at org.eclipse.jface.window.ApplicationWindow.close(ApplicationWindow.java:307)
	at org.eclipse.ui.internal.WorkbenchWindow.hardClose(WorkbenchWindow.java:1735)
	at org.eclipse.ui.internal.WorkbenchWindow.busyClose(WorkbenchWindow.java:734)
	at org.eclipse.ui.internal.WorkbenchWindow.access$0(WorkbenchWindow.java:710)
	at org.eclipse.ui.internal.WorkbenchWindow$5.run(WorkbenchWindow.java:826)
	at org.eclipse.swt.custom.BusyIndicator.showWhile(BusyIndicator.java:52)
	at org.eclipse.ui.internal.WorkbenchWindow.close(WorkbenchWindow.java:824)
	at org.eclipse.jface.window.WindowManager.close(WindowManager.java:109)
	at org.eclipse.ui.internal.Workbench$18.run(Workbench.java:1105)
	at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
	at org.eclipse.ui.internal.Workbench.busyClose(Workbench.java:1102)
	at org.eclipse.ui.internal.Workbench.access$15(Workbench.java:1031)
	at org.eclipse.ui.internal.Workbench$25.run(Workbench.java:1275)
	at org.eclipse.swt.custom.BusyIndicator.showWhile(BusyIndicator.java:52)
	at org.eclipse.ui.internal.Workbench.close(Workbench.java:1273)
	at org.eclipse.ui.internal.Workbench.restart(Workbench.java:2224)
	at org.eclipse.equinox.internal.p2.ui.ProvisioningOperationRunner.requestRestart(ProvisioningOperationRunner.java:75)
	at org.eclipse.equinox.internal.p2.ui.ProvisioningOperationRunner$2.done(ProvisioningOperationRunner.java:127)
	at org.eclipse.core.internal.jobs.JobListeners$3.notify(JobListeners.java:39)
	at org.eclipse.core.internal.jobs.JobListeners.doNotify(JobListeners.java:112)
	at org.eclipse.core.internal.jobs.JobListeners.done(JobListeners.java:152)
	at org.eclipse.core.internal.jobs.JobManager.endJob(JobManager.java:647)
	at org.eclipse.core.internal.jobs.WorkerPool.endJob(WorkerPool.java:105)
	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:71)

!ENTRY org.eclipse.equinox.p2.ui 4 2 2011-10-11 15:32:45.945
!MESSAGE Problems occurred when invoking code from plug-in: "org.eclipse.equinox.p2.ui".
!STACK 0
org.eclipse.swt.SWTException: Invalid thread access
	at org.eclipse.swt.SWT.error(SWT.java:4282)
	at org.eclipse.swt.SWT.error(SWT.java:4197)
	at org.eclipse.swt.SWT.error(SWT.java:4168)
	at org.eclipse.swt.widgets.Display.error(Display.java:1065)
	at org.eclipse.swt.widgets.Display.checkDevice(Display.java:618)
	at org.eclipse.swt.widgets.Display.removeFilter(Display.java:3852)
	at org.eclipse.ui.internal.services.WorkbenchSourceProvider.dispose(WorkbenchSourceProvider.java:108)
	at org.eclipse.ui.internal.services.SourceProviderService.dispose(SourceProviderService.java:64)
	at org.eclipse.ui.internal.services.ServiceLocator.dispose(ServiceLocator.java:142)
	at org.eclipse.ui.internal.Workbench.shutdown(Workbench.java:2981)
	at org.eclipse.ui.internal.Workbench.busyClose(Workbench.java:1114)
	at org.eclipse.ui.internal.Workbench.access$15(Workbench.java:1031)
	at org.eclipse.ui.internal.Workbench$25.run(Workbench.java:1275)
	at org.eclipse.swt.custom.BusyIndicator.showWhile(BusyIndicator.java:52)
	at org.eclipse.ui.internal.Workbench.close(Workbench.java:1273)
	at org.eclipse.ui.internal.Workbench.restart(Workbench.java:2224)
	at org.eclipse.equinox.internal.p2.ui.ProvisioningOperationRunner.requestRestart(ProvisioningOperationRunner.java:75)
	at org.eclipse.equinox.internal.p2.ui.ProvisioningOperationRunner$2.done(ProvisioningOperationRunner.java:127)
	at org.eclipse.core.internal.jobs.JobListeners$3.notify(JobListeners.java:39)
	at org.eclipse.core.internal.jobs.JobListeners.doNotify(JobListeners.java:112)
	at org.eclipse.core.internal.jobs.JobListeners.done(JobListeners.java:152)
	at org.eclipse.core.internal.jobs.JobManager.endJob(JobManager.java:647)
	at org.eclipse.core.internal.jobs.WorkerPool.endJob(WorkerPool.java:105)
	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:71)

Reproducible: Always

Steps to Reproduce:
1. Modify Cloud Update example to apply Policy.RESTART_POLICY_FORCE (eg via PreferenceInitializer.java)
2. Run modified example pointing to a repo which it can update from
3. After update downloaded will raise an ErrorDialog.
Comment 1 Eclipse Genie CLA 2019-04-28 15:29:19 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.
Comment 2 Lars Vogel CLA 2019-10-29 05:32:46 EDT
This bug is marked as stale for some time. If it is still relevant for the current release, please reopen and remove the stalebug whiteboard tag.