Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 360534

Summary: Two find dialogs appear at once when hitting Ctrl+F on Preview tab
Product: z_Archived Reporter: Nicolas Bros <nicolas.bros>
Component: MylynAssignee: Project Inbox <mylyn-triaged>
Status: RESOLVED WONTFIX QA Contact: David Green <greensopinion>
Severity: trivial    
Priority: P3    
Version: 1.5   
Target Milestone: ---   
Hardware: PC   
OS: Windows 7   
Whiteboard:
Attachments:
Description Flags
screenshot
none
mylyn/context/zip none

Description Nicolas Bros CLA 2011-10-11 07:58:50 EDT
Created attachment 204946 [details]
screenshot

- I open a .mediawiki file
- I switch to the Preview tab
- I hit Ctrl+F
I get two "find" dialogs : the browser's native find dialog (I believe it's Internet Explorer's in my case) and the Eclipse editor find dialog : see the attached screenshot

The native dialog works, and the Eclipse find dialog doesn't work on the preview tab since it doesn't know how to search in a SWT Browser. Instead, it searches text in the "source" tab, which is not visible at that time (resulting in a confusing user experience). So, I think the Eclipse find dialog should be prevented from appearing when the editor receives Ctrl+F while on the preview tab.
Comment 1 David Green CLA 2011-10-11 17:04:34 EDT
Thanks for the bug!

Looks like we should probably change the editor context when switching to the preview tab.
Comment 2 David Green CLA 2011-10-11 17:04:37 EDT
Created attachment 204978 [details]
mylyn/context/zip
Comment 3 David Green CLA 2011-11-07 20:20:42 EST
I've tried deactivating the editor context and it's a dead-end: the underlying text editor context is still active.

Thinking that activating a new context when on the preview tab might be the way to go: that way we could register our own find command handler.  Alternatively, we could try capturing the CTRL+F key event and setting @doit=false@.
Comment 4 David Green CLA 2013-08-02 12:44:29 EDT
Closed as part of backlog clean-up.  Please re-open if you'd like to see this revisited, perhaps with a contribution.