Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 360465

Summary:	[Webapp] Remove dependency on org.apache.jasper from org.eclipse.help.webapp
Product:	[Eclipse Project] Platform	Reporter:	Chris Goldthorpe <cgold>
Component:	User Assistance	Assignee:	Chris Goldthorpe <cgold>
Status:	RESOLVED FIXED	QA Contact:
Severity:	minor
Priority:	P3	CC:	eclipse, simon_kaegi, tjwatson
Version:	3.8
Target Milestone:	3.8 M3
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Chris Goldthorpe

2011-10-10 12:59:34 EDT

org.eclipse.help.webapp does not need to depend directly on org.apache.jasper since it already depends on org.eclipse.equinox.jsp.jasper.registry which itself depends on org.apache.jasper. Rather than specifying a version of org.apache.jasper in o.e.help.webapp we should let the equinox bundles select the appropriate version of Jasper.

See also Bug 309529 - Migrate equinox to jetty8

Comment 1 Chris Goldthorpe

2011-10-10 13:50:24 EDT

This change has been committed to master with commit message:

Bug 360465 - [Webapp] Remove dependency on org.apache.jasper from org.eclipse.help.webapp

Comment 2 Thomas Watson

2011-10-11 09:44:50 EDT

I started thinking about this a bit and it occurred to me that the webapp may have needed the dependency to org.apache.jasper at some point because of the compiled jsp classes.  So I started to trace the code and it appears the pre-compiled jsps are never used at runtime.

Chris, are you certain these precompiled JSPs get used at runtime?

Comment 3 Chris Goldthorpe

2011-10-11 11:01:51 EDT

No, I'm not certain. I'll look into that.

Comment 4 Holger Voormann

2011-12-19 12:24:41 EST

(In reply to comment #3)
> No, I'm not certain. I'll look into that.
>
The pre-compiled JSP classes are not used. See bug 367102.