Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 360421

Summary: [Navigator & Editor Sockets] org.eclipse.sphinx.emf.explorer bug fixes and enhancements
Product: [Automotive] Sphinx Reporter: Lan Phan <quoclan>
Component: CoreAssignee: Stephan Eberle <stephaneberle9>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: dao.hoang.gate, idydieng, r.sezestre
Version: 0.7.0   
Target Milestone: 0.7.0   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
Patch for org.eclipse.sphinx.emf.explorer project idydieng: iplog+

Description Lan Phan CLA 2011-10-10 06:06:49 EDT
Build Identifier: 

Bugs:
1. BasicDropAdapterAssistant#getSelectedEObjects(IStructuredSelection):
...
else if (o instanceof WrapperItemProvider) {
				selectedEObject.add((EObject) ((WrapperItemProvider) o).getValue());
}
...
IWrapperItemProvider.getValue() can be TransientItemProvider object --> ClassCastException

2. CloseResourceOverrideAction: initAction() is declared but not called in constructor


Enhancements:
1. Add javadoc
2. Externalize messages
3. Remove unused attribute 'shellProvider' in CloseResourceOverrideAction
4. IWrapperItemProvider and WrapperItemProvider are used concurrently in BasicDropAdapterAssistant --> modify to use only IWrapperItemProvider

Reproducible: Always
Comment 1 Lan Phan CLA 2011-10-10 06:16:13 EDT
Created attachment 204866 [details]
Patch for org.eclipse.sphinx.emf.explorer project

Proposed patch in attachment
Comment 2 Stephan Eberle CLA 2011-10-17 08:44:04 EDT
Fixed by applying proposed patch. 

Thank you for this valuable contribution!
Comment 3 Balazs Grill CLA 2021-07-14 02:16:46 EDT
Mass-closing Resolved tickets