Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 360382

Summary: "Disable" does NOT work for CheckBox
Product: z_Archived Reporter: Yu Hao <yuhaodl>
Component: EDTAssignee: Huang Ji Yong <hjiyong>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: greer, hjiyong, yuhaodl
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
fix lasher: iplog+

Description Yu Hao CLA 2011-10-10 02:23:25 EDT 
Build Identifier: 201110082101

The property of "Disable" for CheckBox does not work in preview nor deploy mode

Reproducible: Always
Comment 1 Huang Ji Yong CLA 2011-10-12 05:33:42 EDT 
This is a JSGen defect.
The generation for Checkbox.egl is wrong
        function setDisabled(disabled Boolean in)
		check.disabled = disabled;
		span.disabled = disabled;
	end

generated js is:
"setDisabled": function(disabled) {
   this.check.disabled = disabled; // should be this.check.setDisabled(disable)
   this.span.disabled = disabled; // The same as the last line
}
Comment 2 Yu Hao CLA 2011-10-13 02:12:41 EDT 
The property "disable" for widget "List" only works in preview mode of internal browser. It does not work in preview with external browser and deploy mode
Comment 3 Yu Hao CLA 2011-10-13 03:44:16 EDT 
ListMutli has the same issue with List
Comment 4 Huang Ji Yong CLA 2011-10-24 02:06:07 EDT 
The checkbox problem is a js gen problem.
But the list/listMulti disabled is not a problem, it is just a display difference across browsers.

Scott, please review my patch.
Thanks.
Comment 5 Huang Ji Yong CLA 2011-10-24 02:07:09 EDT 
Created attachment 205780 [details]
fix
Comment 6 Scott Greer CLA 2011-10-24 10:26:27 EDT 
Ji Yong,

Fix looks good -- please commit....thanks!
Comment 7 Huang Ji Yong CLA 2011-10-24 21:41:56 EDT 
Fixed
Comment 8 Yu Hao CLA 2011-11-02 01:44:36 EDT 
Verified in 201111012101