Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 360368

Summary:	[key binding] Hot Key for Skip All Breakpoints
Product:	[Eclipse Project] JDT	Reporter:	Diogo Santana <diogosantana>
Component:	Debug	Assignee:	Markus Keller <markus.kell.r>
Status:	VERIFIED FIXED	QA Contact:
Severity:	enhancement
Priority:	P3	CC:	daniel_megert, markus.kell.r, Michael_Rennie, noopur_gupta, pawel.1.piech, remy.suen, sarika.sinha
Version:	3.8
Target Milestone:	4.5 M6
Hardware:	All
OS:	All
Whiteboard:

Description Diogo Santana

2011-10-09 17:25:59 EDT

Build Identifier:  20110916-0149

I am a developer and I always add two hot keys to Skip All Breakpoints and Remove All Breakpoints commands. I use it a lot and think it could help others if the original JDT comes with these hot keys.
I use Ctrl + Alt + S to Skip all and Ctrl + Alt + R to Remove All. They aren't binding in original JDT.

Reproducible: Always

Steps to Reproduce:
1. Add Ctrl + Alt + S to Skip All Breakpoints command
2. Add Ctrl + Alt + R to Remove All Breakpoints command
3. Use it. :)

Sorry, as this is a simple enhancement suggestion, I dont know what exactly to put here.

Comment 1 Remy Suen

2011-10-09 18:00:37 EDT

Personally I don't see much value in this if the user can already define one.

Comment 2 Dani Megert

2011-10-10 04:37:26 EDT

(In reply to comment #1)
> Personally I don't see much value in this if the user can already define one.
Same here.

Comment 3 Pawel Piech

2011-10-10 12:30:06 EDT

It's worth noting that we've added the skip-all action to the main toolbar (bug 264485).  It's part of a larger change to the debug toolbar, so if it sticks, it should help this use case.

Comment 4 Michael Rennie

2013-12-06 15:29:14 EST

Closing wontfix, you can set a keybinding on the 'Keys' preference page if you really want to, but I also see no value in having one by default.

Comment 5 Markus Keller

2015-02-17 05:33:19 EST

Predefined shortcuts should be reserved for often-used commands. "Remove All Breakpoints" is not used that often, so I don't think we should assign a shortcut.

But "Skip All Breakpoints" is used often. I use it even more than "Toggle Breakpoint", and I can't work efficiently without assigning a shortcut.

We should use Ctrl+Alt+B for "Skip All Breakpoints". This shortcut is still free in eclipse-jee-mars-M5-win32-x86_64, and it's a nice complement to the already assigned Ctrl+Shift+B for "Toggle Breakpoints".

Comment 6 Dani Megert

2015-02-17 06:02:08 EST

(In reply to Markus Keller from comment #5)
> Predefined shortcuts should be reserved for often-used commands. "Remove All
> Breakpoints" is not used that often, so I don't think we should assign a
> shortcut.
> 
> But "Skip All Breakpoints" is used often. I use it even more than "Toggle
> Breakpoint", and I can't work efficiently without assigning a shortcut.
> 
> We should use Ctrl+Alt+B for "Skip All Breakpoints". This shortcut is still
> free in eclipse-jee-mars-M5-win32-x86_64, and it's a nice complement to the
> already assigned Ctrl+Shift+B for "Toggle Breakpoints".

+1.

Comment 7 Markus Keller

2015-02-18 08:04:41 EST

Fixed with http://git.eclipse.org/c/platform/eclipse.platform.debug.git/commit/?id=87bf3db976790862ceb9b321661e0234afb342ca

The commit also makes sure the "Skip All Breakpoints" button in the Breakpoints view shows the command's shortcut in the tooltip.

Comment 8 Diogo Santana

2015-02-18 11:59:17 EST

Just for curiosity about '"Remove All Breakpoints" is not used that often'. Do you guys collect data about usage?

I'm asking because I always add the two shortcuts and during programming I use those often and I actually use more the "Remove All".

I am glad you finally add a predefined shortcut, but I a little bit 
disappointed because the "Remove All" won't be included.

Anyway, keep up with the great Eclipse job and tanks for add the shortcut.

Comment 9 Sarika Sinha

2015-03-16 06:59:25 EDT

Verified using 
Eclipse SDK

Version: Mars (4.5)
Build id: I20150315-2000