Bugzilla – Full Text Bug Listing
| Summary: | remove work-arounds for legacy Bugzilla versions | ||
|---|---|---|---|
| Product: | z_Archived | Reporter: | Steffen Pingel <steffen.pingel> |
| Component: | Mylyn | Assignee: | Project Inbox <mylyn-triaged> |
| Status: | CLOSED MOVED | QA Contact: | |
| Severity: | enhancement | ||
| Priority: | P3 | CC: | eclipse, robert.elves, shawn.minto, steffen.pingel |
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Bug Depends on: | |||
| Bug Blocks: | 359210 | ||
|
Description
Steffen Pingel
Frank, let's touch base before we start on this. This might make most sense as part of bug 359210 and I am not sure if we'll get to that for 3.7. Steffen, I have create review http://review.mylyn.org/#change,88 I add the following changes: we use BugzillaVersion instead of String Constants * Dialog "Add Task Repository" now show "Bugzilla (supports <BugzillaVersion.Min_Version> to <BugzillaVersion.Max_Version>) * Dialog "Properties for Task Repository " show "Supports Bugzilla <BugzillaVersion.Min_Version> - <BugzillaVersion.Max_Version>" Is this OK? Sorry, if I wasn't clear about the in the intended scope of this bug. We should not remove support for older and no longer supported Bugzilla versions unless this puts a significant burden on the project. Bug 355737 merely defines the Bugzilla versions that we test against and advertise as supported. If a version is not listed it only means that we do not know whether it is compatible and we are unlikely to prioritize support requests for those versions. Frank, I would hence like to ask you to not submit the proposed changes since most of the removed code portions are trivial and we have no driver to remove them at this point. The only exception being support for Bugzilla 2.18. That versions is old enough that I don't see any reason to maintain support at all. (In reply to comment #2) > I add the following changes: we use BugzillaVersion instead of String Constants > * Dialog "Add Task Repository" now show "Bugzilla (supports > <BugzillaVersion.Min_Version> to <BugzillaVersion.Max_Version>) > * Dialog "Properties for Task Repository " show "Supports Bugzilla > <BugzillaVersion.Min_Version> - <BugzillaVersion.Max_Version>" I don't see any benefit in this change. Usually, the Bugzilla connector is compatible with future Bugzilla versions and I would not want to discourage users from trying a version that may not be listed as compatible. The connector code should definitely not throw exceptions when an unsupported version is encountered unless it is known to be broken. We could verify the Bugzilla version during validation and display a warning if the discovered version is unsupported. This should only require minor changes to the validation logic in the repository settings page and should be tracked on a different bug. The Trac connector has similar code that can be used as an example. I'm taking this off the plan since it's not clear if we will have sufficient capacity to resolve bug 359210 for 3.7. Steffen, I think we should take the changes from comment #2 to not have more the one place that we need to change when the min version is changed. Also I think we should call the validation if a user hit the Finish button and display a warning if the user use an version less the supported min version Thougths? (In reply to comment #4) > Steffen, > > I think we should take the changes from comment #2 to not have more the one > place that we need to change when the min version is changed. Sound reasonable if the message still says "{0} or later". Can you file a bug for that? > Also I think we should call the validation if a user hit the Finish button and > display a warning if the user use an version less the supported min version Sure, as long as this is done as part of the standard validation and only displayed as a non-blocking message, i.e. in the message area of wizard. We can make that change as part of the change suggested above. It makes sense to me to support validation on finish but this should be handled on a framework level. Can you file a subtask of bug 336434 to track that? Thanks! Mylyn has been restructured, and our issue tracking has moved to GitHub [1]. We are closing ~14K Bugzilla issues to give the new team a fresh start. If you feel that this issue is still relevant, please create a new one on GitHub. [1] https://github.com/orgs/eclipse-mylyn |