Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 360275

Summary:	Need a generic way to add sorter UI in explorer.
Product:	[ECD] Orion	Reporter:	libing wang <libingw>
Component:	Client	Assignee:	Project Inbox <orion.client-inbox>
Status:	RESOLVED WONTFIX	QA Contact:
Severity:	normal
Priority:	P3	CC:	john.arthorne, libingw, malgorzata.tomczyk, mamacdon, simon_kaegi, susan, Szymon.Brandys
Version:	unspecified
Target Milestone:	---
Hardware:	PC
OS:	Windows 7
Whiteboard:
Bug Depends on:
Bug Blocks:	339483, 339484, 359849, 361305, 365450

Description libing wang

2011-10-07 15:27:59 EDT

While I am holding off for the final solution of Bug 359849, I am thinking about the requirement in a generic way.
I would like to use this bug as post-0.3 discussion on explorer sorters.

What I think about the ability to sort in the search explorer is:
1. The common header UI, e.g. : a button that is aligned to width of the column, which has up-arrow and down-arrow toggled when user clicks it.
2. The internal callback functions on these sorter buttons can be registered by the tree model so that they are easy to switch.
3.Also, we should be clear enough in a tree view , what does sort means.

Comment 1 Susan McCourt

2011-10-10 13:59:59 EDT

I agree we need to think generically about nav/list sorting.  I was worried about us adding something in one place and then users expecting it in similar presentations.

The use case in bug 359849 was that I want to see a flat list of search results found in "org.eclipse.orion.client.core".  So I would sort by location as a way of ignoring hits in other bundles.  (If we had server-side filtered search, I could filter the search by that folder, but in the absence of that, sorting could help me look through the results.)

In search results, or anywhere that we have a full list of items, we could do client-side sorting.  Note we already do this today, we just hard-code the sorting to name.  (see bundles/org.eclipse.orion.client.core/web/orion/util.js?line=354).

However, column-based sorting could be misleading in other places, particularly in paged views like git-log, where sorting makes more sense from the server side.

> 3.Also, we should be clear enough in a tree view , what does sort means.
Today we sort each level, so the folders are sorted by name, as are the folder contents.  If there is a case where we are sorting on some property that files (or whatever the leaf of the tree is) have, but the parents do not, then we would probably default to sort by name on parents and by the property on leaves...

Comment 2 Susan McCourt

2012-09-13 11:43:09 EDT

I'm going to take a look at this while sorting out the explorer/model/renderer API.

Comment 3 Susan McCourt

2012-09-20 12:09:15 EDT

moving out of 1.0, I was being too optimistic.

Comment 4 John Arthorne

2015-05-05 14:41:30 EDT

Closing as part of a mass clean up of inactive bugs. Please reopen if this problem still occurs or is relevant to you. For more details see:

https://dev.eclipse.org/mhonarc/lists/orion-dev/msg03444.html