Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 360259

Summary: R4E Short key generates an exception
Product: z_Archived Reporter: Jacques Bouthillier <lmcbout>
Component: MylynAssignee: Sebastien Dubois <sebastien.dubois>
Status: RESOLVED DUPLICATE QA Contact:
Severity: normal    
Priority: P3 CC: alvaro.sanchez-leon, lmcbout, sebastien.dubois
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Windows Vista   
Whiteboard:

Description Jacques Bouthillier CLA 2011-10-07 13:19:53 EDT
To reproduce: Window and LINUX:
-Close the R4E Navigator view
- Select a project in the Package Explorer
- Short Key: "Alt + 4, O"  
--> Generates the following error


!STACK 0
java.lang.ClassCastException: org.eclipse.jdt.internal.core.JavaProject cannot be cast to org.eclipse.mylyn.reviews.r4e.ui.internal.model.IR4EUIModelElement
	at org.eclipse.mylyn.reviews.r4e.ui.internal.editors.EditorProxy.openEditor(EditorProxy.java:105)
	at org.eclipse.mylyn.reviews.r4e.ui.internal.commands.OpenEditorHandler$1.runInUIThread(OpenEditorHandler.java:62)
	at org.eclipse.ui.progress.UIJob$1.run(UIJob.java:95)
	at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35)
	at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:135)
	at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:4140)
Comment 1 Sebastien Dubois CLA 2011-10-12 16:52:15 EDT
Problem is fixed for the command that actually have shortkeys.  If we add new shortkeys, the handler dealing with the commands will have to be verified as well.
Comment 2 Alvaro Sanchez-Leon CLA 2011-10-25 22:09:16 EDT
The issue still happens, sometimes when short key for "go into" or open review item


eclipse.buildId=M20110210-1200
java.version=1.6.0_26
java.vendor=Sun Microsystems Inc.
BootLoader constants: OS=win32, ARCH=x86, WS=win32, NL=en_CA
Framework arguments:  -showlocation
Command-line arguments:  -os win32 -ws win32 -arch x86 -showlocation


Error
Tue Oct 25 21:57:29 EDT 2011
Unhandled event loop exception

org.eclipse.swt.SWTException: Widget is disposed
	at org.eclipse.swt.SWT.error(SWT.java:4083)
	at org.eclipse.swt.SWT.error(SWT.java:3998)
	at org.eclipse.swt.SWT.error(SWT.java:3969)
	at org.eclipse.swt.widgets.Widget.error(Widget.java:468)
	at org.eclipse.swt.widgets.Widget.checkWidget(Widget.java:340)
	at org.eclipse.swt.widgets.Tree.getItems(Tree.java:3248)
	at org.eclipse.jface.viewers.TreeViewer.getChildren(TreeViewer.java:171)
	at org.eclipse.jface.viewers.AbstractTreeViewer.internalCollectVisibleExpanded(AbstractTreeViewer.java:2844)
	at org.eclipse.jface.viewers.AbstractTreeViewer.getVisibleExpandedElements(AbstractTreeViewer.java:2839)
	at org.eclipse.mylyn.reviews.r4e.ui.internal.commands.filters.GoIntoFilterHandler.execute(GoIntoFilterHandler.java:56)
	at org.eclipse.ui.internal.handlers.HandlerProxy.execute(HandlerProxy.java:293)
	at org.eclipse.core.commands.Command.executeWithChecks(Command.java:476)
	at org.eclipse.core.commands.ParameterizedCommand.executeWithChecks(ParameterizedCommand.java:508)
	at org.eclipse.ui.internal.handlers.HandlerService.executeCommand(HandlerService.java:169)
	at org.eclipse.ui.internal.keys.WorkbenchKeyboard.executeCommand(WorkbenchKeyboard.java:468)
	at org.eclipse.ui.internal.keys.KeyAssistDialog.executeKeyBinding(KeyAssistDialog.java:551)
	at org.eclipse.ui.internal.keys.KeyAssistDialog.access$0(KeyAssistDialog.java:544)
	at org.eclipse.ui.internal.keys.KeyAssistDialog$1.handleEvent(KeyAssistDialog.java:516)
	at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1053)
	at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4066)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3657)
	at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2640)
	at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2604)
	at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2438)
	at org.eclipse.ui.internal.Workbench$7.run(Workbench.java:671)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
	at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:664)
	at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
	at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:115)
	at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:369)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:597)
	at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:620)
	at org.eclipse.equinox.launcher.Main.basicRun(Main.java:575)
	at org.eclipse.equinox.launcher.Main.run(Main.java:1408)
Comment 3 Sebastien Dubois CLA 2011-10-26 11:20:37 EDT
This error is a different one than what was happening.  We should open a new bug for this
Comment 4 Alvaro Sanchez-Leon CLA 2011-10-26 11:59:32 EDT
The user scenario is the same, 
The scenario shall work for all key combinations and shall have no exceptions, this issue is not dependent on exception signatures.
Comment 5 Sebastien Dubois CLA 2011-10-26 16:10:11 EDT
What I mean is that the exception that is generated is different than the one that was generated before.  So the initial problem is fixed, but there are still issues with the shortcuts
Comment 6 Jacques Bouthillier CLA 2012-02-27 10:51:31 EST
- Initial description fix with Bug 362259
- The issue with short key for "go into" fixed with this bug release
Comment 7 Jacques Bouthillier CLA 2012-02-27 11:06:33 EST
Duplication

*** This bug has been marked as a duplicate of bug 362259 ***