Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 360204

Summary:	Make RWTServletContextListener and RWTDelegate API
Product:	[RT] RAP	Reporter:	Rüdiger Herrmann <ruediger.herrmann>
Component:	RWT	Assignee:	Project Inbox <rap-inbox>
Status:	RESOLVED FIXED	QA Contact:
Severity:	enhancement
Priority:	P3	CC:	fr.appel, rsternberg
Version:	unspecified
Target Milestone:	1.5 M3
Hardware:	All
OS:	All
Whiteboard:

Description Rüdiger Herrmann

2011-10-07 04:37:47 EDT

A common way to work with RWT standalone is to declare the RWTDelegate and RWTServletContextListener in the web.xml. (e.g. as desribed in the FAQ http://wiki.eclipse.org/RAP/FAQ#How_do_I_use_an_RWT_standalone_application_in_Tomcat). Both classes are in packages marked internal. But as they are necessary to run RWT they should become part of the public API. 

I propose to create a package org.eclipse.rwt.engine (or use the existing ...application package?) and move both classes there. To preserve backwards-compaibility we could also put classes that derive from the respective class into the public package.

Comment 1 Frank Appel

2011-10-07 04:57:50 EDT

In this context we could probably change the name of RWTDelegate to somewhat more conclusive...

Comment 2 Ralf Sternberg

2011-10-08 11:44:28 EDT

How about RWTServlet? This seems to be the obvious name.

Comment 3 Frank Appel

2011-10-08 14:48:47 EDT

(In reply to comment #2)
> How about RWTServlet? This seems to be the obvious name.
+1

Comment 4 Rüdiger Herrmann

2011-10-13 17:32:56 EDT

I introduced an 'org.eclipse.rwt.engine' package and put
* RWTServlet (extends RWTDelegate) and 
* RWTServletContextListener (extends internal RWTServletContextListener)
there.
Please re-open if you disagree or if you can suggest a better name for RWTServletContextListener

Comment 5 Frank Appel

2011-10-14 02:19:51 EDT

I think we should remove Application#createServlet() and use the new RWTServlet directly before we resolve this bug.

Comment 6 Ralf Sternberg

2011-10-14 06:06:53 EDT

(In reply to comment #5)
> I think we should remove Application#createServlet() and use the new RWTServlet
> directly before we resolve this bug.
+1

Comment 7 Rüdiger Herrmann

2011-10-14 08:33:47 EDT

(In reply to comment #5)
> I think we should remove Application#createServlet() and use the new RWTServlet
> directly before we resolve this bug.
Of course. Changes are in CVS HEAD

Comment 8 Rüdiger Herrmann

2011-10-21 11:20:36 EDT

Even though this is a breaking change, we finally decided to move RWTDelegate and RWTServletContextListener to the API package o.e.rwt.engine.
Changes are in CVS HEAD