Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 360162

Summary: P2 Feature Patch installs but the patched plugin doesn't
Product: [Eclipse Project] Equinox Reporter: Hugo Corbucci <nightao>
Component: p2Assignee: P2 Inbox <equinox.p2-inbox>
Status: RESOLVED WONTFIX QA Contact:
Severity: normal    
Priority: P3    
Version: 3.7   
Target Milestone: ---   
Hardware: All   
OS: All   
See Also: https://bugs.eclipse.org/bugs/show_bug.cgi?id=240370
https://bugs.eclipse.org/bugs/show_bug.cgi?id=531249
Whiteboard: stalebug
Attachments:
Description Flags
The profile before installing the patch
none
The metadata repository on the update.site
none
The artifacts repository none

Description Hugo Corbucci CLA 2011-10-06 15:40:34 EDT 
Build Identifier: I20110613-1736

I created a feature patch:
com.o2filmes.storytouch.minimal.patch.feature - version 1.0.0
This feature patch includes only one plugin:
com.o2filmes.storytouch.update - version 1.0.0.3796
This patch is included in the feature:
com.o2filmes.storytouch.basic.feature - version 1.0.0.3802-7l7bFBVF70uIUaexdsLM9GN4H24K

The platform to which I am installing these features and patches and plugins is from my own build 3704.
It contains com.o2filmes.storytouch.minimal.feature - version 1.0.0.3675-7F-39wQLCNLSOM0z0Pu-5pUxJY-r which is the target feature and adds com.o2filmes.storytouch.update - version 1.0.0.3685.

I generated the p2 repository with the patch over build 3704.

When I install com.o2filmes.storytouch.basic.feature - version 1.0.0.3802-7l7bFBVF70uIUaexdsLM9GN4H24K over the build 3704 with an UpdateOperation, the operation is successful, the feature is updates, the patch feature is added but com.o2filmes.storytouch.update plugin stays at version 1.0.0.3685.

Reproducible: Always

Steps to Reproduce:
1. Download StoryTouch from http://www.storytouch.com/3703/StoryTouch-Basic-macosx.cocoa.x86_64.zip or http://www.storytouch.com/3703/StoryTouch-Basic-win32.win32.x86.zip
2. unzip it somewhere (say /tmp/StoryTouch)
3. install the iu using '/tmp/eclipse/eclipse -application org.eclipse.equinox.p2.director -repository http://update.storytouch.com/test -installIU com.o2filmes.storytouch.minimal.patch.feature.feature.group -destination /tmp/StoryTouch/'
4. Operation is successful, patch is installed but update plugin is not updated.
Comment 1 Hugo Corbucci CLA 2011-10-06 15:44:04 EDT 
Created attachment 204712 [details]
The profile before installing the patch

As request by Pascal, this is the profile before any installation happens
Comment 2 Hugo Corbucci CLA 2011-10-06 15:45:31 EDT 
Created attachment 204713 [details]
The metadata repository on the update.site

Another install
Comment 3 Hugo Corbucci CLA 2011-10-06 15:46:13 EDT 
Created attachment 204714 [details]
The artifacts repository
Comment 4 Hugo Corbucci CLA 2011-10-06 15:55:48 EDT 
To generate the patch, I followed instructions from:
Andrew Niefer's blog - http://aniefer.blogspot.com/2009/06/patching-features-with-p2.html
Andrew Niefer's blog - http://aniefer.blogspot.com/2009/06/patching-features-part-2.html

I double checked everything by reading:
p2-dev archives - http://www.mail-archive.com/p2-dev@eclipse.org/msg00633.html

I've tried to increase the patch scope changing the content.xml manually. Apparently it works but there is no info on the update plugin not being updated.
Comment 5 Eclipse Genie CLA 2018-10-14 14:02:26 EDT 
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.
Comment 6 Lars Vogel CLA 2019-10-08 10:46:44 EDT 
This bug was marked as stalebug a while ago. Marking as wontfix.

If this report is still relevant for the current release, please
reopen and remove the stalebug whiteboard tag.