Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 360129

Summary:

wrong version of jdt compiler appears to be being used

Product:

[WebTools] WTP Releng

Reporter:

David Williams <david_williams>

Component:

releng

Assignee:

David Williams <david_williams>

Status:

ASSIGNED ---

QA Contact:

Carl Anderson <ccc>

Severity:

normal

Priority:

CC:

ccc, tranle1

Version:

unspecified

Target Milestone:

---

Hardware:

OS:

Windows 7

Whiteboard:

Attachments:

Description	Flags
fixing for dependency scripts	none
Correction for dependency scripts patch	none

Description David Williams

2011-10-06 12:18:47 EDT

While discussing another issue with Carl, we noticed the wrong version of JDT compiler appears to be being used to do the WTP compilations. 

For example, a recent log might say it was compiled with: 

Compiler: Eclipse Compiler for Java(TM) Version: 0.C13, 3.8.0 M3

but the 'eclipsebuilder' values still imply "3.7.0"

eclipsebuilder.id=3.7RC3
eclipsebuilder.dir=S-3.7RC3-201105261708

We looked back at "history" of builds, and it appears it has been this way for a long time (that is, that the compiler we use is what is in the 'eclipse' prereq, such as

eclipse.id=I20111004-1128
eclipse.dir=I20111004-1128

instead of the eclipsebuilder prereq

So, not good ... for stability/predictability reasons ... but, not sure if is causing any problem, per se.

Comment 1 David Williams

2011-10-06 12:27:19 EDT

Created attachment 204688 [details]
fixing for dependency scripts

It appears a simply "copy paste" error has always existed. 

Easy enough to fix ... but, this means the builds have not been working as they were thought to be working ... so, applying the fix might result in other errors showing up ... that is, a "test build" on a "local" machine would be in order :)

Comment 2 David Williams

2011-10-06 13:10:47 EDT

Findings so far, from local build, first attempt showed "no change" which was odd, but then remembered that we "cache" the base builder directories, thinking they do not change often. So, removed old versions (from my local machine) and then discovered that the "RC3" version no longer exists (naturally) so I went ahead and updated to 3.7.1 release version: 

eclipsebuilder.id=3.7.1
eclipsebuilder.dir=R-3.7.1-201109091335

Downloading now ... stay tuned.

Comment 3 David Williams

2011-10-06 13:39:55 EDT

The test on my local machine finished fine, and now JSDT compile logs correctly show 

Compiler: Eclipse Compiler for Java(TM) Version: 0.B76_R37x, 3.7.1

Comment 4 David Williams

2011-10-06 13:48:17 EDT

Now, to complete the fix, all that's needed is to remove cached builders from build.eclipse.org. Which ones? Currently there are cached base builders for 

3.6.2
jsdt-R1.2.1-M
jsdt-R1.4.0-I
RC2_34
wtp4x-R3.4.0-I
wtp-R3.2.5-M
wtp-R3.3.1-M
wtp-R3.3.2-M
wtp-R3.4.0-I

I'm going to go ahead and remove the cached versions for following: 

jsdt-R1.2.1-M
jsdt-R1.4.0-I
wtp4x-R3.4.0-I
wtp-R3.4.0-I

Less sure about others ... if needed or not ... plus, the "branched" versions of 'releng' may have to be fixed to pick up correct dependency properties. 

So, will leave bug open, and let Carl and/or Tran chime in on finishing touches.

Comment 5 Tran Le

2011-10-06 22:14:38 EDT

(In reply to comment #4)

> Less sure about others ... if needed or not ... plus, the "branched" versions
> of 'releng' may have to be fixed to pick up correct dependency properties. 
> 
> So, will leave bug open, and let Carl and/or Tran chime in on finishing
> touches.

David, I've applied the patch. Thanks.

Comment 6 Tran Le

2011-10-09 17:52:24 EDT

Created attachment 204843 [details]
Correction for dependency scripts patch

Correction to indigo / dependencies.properties

eclipsebuilder.mirror.prefixuri=/eclipse/downloads/drops/${eclipsebuilder.dir}
eclipsebuilder.url=http://download.eclipse.org${eclipsebuilder.mirror.prefixuri}

instead of: 

eclipsebuilder.mirror.prefixuri=/eclipse/downloads/drops/${eclipsebuilder.id}
eclipsebuilder.url=http://download.eclipse.org${eclipse.mirror.prefixuri}