Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 360118

Summary:	reorganize core CSS files
Product:	[ECD] Orion	Reporter:	Susan McCourt <susan>
Component:	Client	Assignee:	Anton McConville <antonm>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	antonm, eclipse, mamacdon, pwebster, simon_kaegi, Szymon.Brandys
Version:	unspecified
Target Milestone:	1.0
Hardware:	PC
OS:	Windows 7
Whiteboard:
Bug Depends on:
Bug Blocks:	369427

Description Susan McCourt

2011-10-06 11:53:45 EDT

the CSS files for client core have grown rather haphazardly.
Some issues are already documented (bug 359896, bug 360041).

In particular:

- should dojo css be separate from non-dojo css (commands.css mixes both)
- do we want a dir structure that separates widget oriented css (dojo stuff, editor theming, etc.) from the rest of client core?  Similarly do we want separate sprites and have image subdirs so that generation of CSS for images (be it sprites or data URI's) is more organized?
- command image definition doesn't belong in commands.css.  This file should mainly be for classes the framework itself uses.  Core sprites should probably be in ide.css or if we split that file up, somewhere else.

More generally...
Simon suggested we look at
http://smacss.com/book/

Also see what the editor is doing in bug 360099

Comment 1 Susan McCourt

2012-01-23 12:31:58 EST

We also should also separate styles that affect the Orion "chrome" from styles that are more specific to inner implementations of pages.  That would make it easier for someone to reskin orion.

Comment 2 Mark Macdonald

2012-05-01 13:38:36 EDT

Currently, ide.css contains styles for a bunch of distinct components:

- banner/common HTML fragments
- upload widget
- navigator table (also 'treetable' widget? not sure)
- outliner
- content assist panel
- landing page
- status/progress
- command parameters
- unit test

As a first reorganization step, we could split these up into separate css files.

Comment 3 Anton McConville

2012-07-25 14:06:54 EDT

I introduced theme.css in my last update. I think we'll continue to make changes when LESS is introduced

Comment 4 Susan McCourt

2012-08-09 15:25:22 EDT

I did a little more reorg (in it's a branch now, will get pushed when bug 383827 lands).

- the breadcrumb classes were moved by Anton to theme.css so I removed breadcrumb.css and checked that all classes were accounted for

- some of the command classes were moved by Anton to theme.css.  I moved the remaining command classes that involved the color/bordering of all command elements.  This includes some dijit theme overrides.  My feeling is that all of these things need to live together, even if not all of them are currently driven by themes.  For example, the margins of them relate to each other, etc., and it's easier to deal with them together.  I would expect over time more of these values will be driven off a theme.  Sorry for the clutter, Anton.

- I moved command layout classes to layout.css.

- all that was left in commands.css were sprite so I renamed the file images.css.  I've always wanted to have the images isolated, so this is improved.

Comment 5 Susan McCourt

2012-08-15 16:54:29 EDT

The changes mentioned in the previous comment have been pushed.
I did some additional cleanup in
http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=f7149f9ba229e7521fd8710af72fc01286bad1ba

I'm trying to move page-specific classes (such as unit test classes) into the page's css file thus making ide.css smaller.  I also removed some dijit overrides that were used for the banner and are no longer needed.

There seems to be a lot of navigator-specific stuff in ide.css but I'll deal with that in bug 378124

Comment 6 Anton McConville

2012-08-29 10:30:55 EDT

Closing this. I think we've got to a good place with this now.