Bugzilla – Full Text Bug Listing
| Summary: | History view must not filter changed files of a commit | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Technology] EGit | Reporter: | Dani Megert <daniel_megert> | ||||
| Component: | UI | Assignee: | Kevin Sawicki <kevin> | ||||
| Status: | VERIFIED FIXED | QA Contact: | |||||
| Severity: | major | ||||||
| Priority: | P3 | CC: | christian.halstrick, markus.kell.r, robin | ||||
| Version: | 1.2 | ||||||
| Target Milestone: | --- | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
Wow, this is really unexpected! At least, I can copy the commit id and use Open Git Commit... to see all files, but this makes the file list in the history view useless when the view is in file mode. If you want to keep the filter, then please just render the hidden files a bit differently and maybe put them to the end of the list, but don't hide them completely. *** Bug 345437 has been marked as a duplicate of this bug. *** Proposed fix pushed to: http://egit.eclipse.org/r/4565 Which diff would you expect for the files in the list if you compare it with the ancestor? - The diff compared to the real parent of the commit - The diff to the parent commit in the filtered tree For the file(s) used for filtering the diffs are the same, but not for the others. I think this was the reason that the filtering was also used for the file list. I would always expect the diff to the real parent of the current commit (same as if the History view shows the whole repository). Multi-selection and "Compare with ..." can be used to compare two commits that are farther apart. Fixed with 82939b12c643826bae97bfc60d65ba7147cc6f4f Verified in 1.2.0.201111150513. (In reply to comment #1) > If you want to keep the filter, then please just render the hidden files a > bit differently and maybe put them to the end of the list, but don't hide > them completely. See bug 393610 for this. |
Created attachment 204655 [details] Picture showing bug 1.2.0.201110021920 The History view also applies the filters which filter commits to the changed files section of an individual commit (see attached picture). This is very bad! I cherry-picked such a commit which resulted in tons of other changes that I didn't want.