Bug 360055

Comment 1 Steffen Pingel 2011-10-06 15:12:20 EDT

Sounds like a good idea. I have marked the bug as helpwanted to indicate that community contributions are welcome to resolve this.

Comment 2 Sam Davis 2012-03-12 16:46:52 EDT

Created attachment 212502 [details]
patch

Steffen, what do you think of this? It seems reasonable to me if there are no queries defined to just set the preference without a prompt.

Comment 3 Sam Davis 2012-03-12 16:46:55 EDT

Created attachment 212503 [details]
mylyn/context/zip

Comment 4 Steffen Pingel 2012-05-23 17:03:29 EDT

I'm -2 on showing a modal dialog on tasks UI startup. We could consider doing this as an embedded notification in the task list though.

Comment 5 Sam Davis 2012-05-23 17:16:09 EDT

That seems reasonable... is there any framework support for such notifications?

Comment 6 Steffen Pingel 2012-05-23 17:53:52 EDT

Yes, TaskListServiceMessageControl has code for showing notifications in the task list.

Comment 7 Sam Davis 2012-05-23 18:19:44 EDT

Cool, I'll take a look at that.

Comment 8 Sam Davis 2012-08-21 20:41:52 EDT

I've pushed a review using TaskListServiceMessageControl. I had to improve the modularity of it as it doesn't really support having more than one control, because they all use the same preference constants. I didn't see any good way to reuse the existing control, which gets its messages from the message manager.

7340: 360055: prompt users to disable "Show subtasks not Matching Query" [I5a14e200]
https://git.eclipse.org/r/#change,7340

Comment 9 Mik Kersten 2013-02-06 00:12:26 EST

Steffen: Is there any reason not to proceed with this patch?

Comment 10 Steffen Pingel 2013-02-06 05:40:45 EST

No particular reason. I just don't think anyone has looked at it, yet.

Comment 11 Steffen Pingel 2013-02-06 19:44:34 EST

The change looks good. The only thing I am wondering if it is feasible to reuse the existing service message control in the task list rather than creating a control in TasksUiPlugin? The idea is that there is a single control for notifying the user.

Mik, do you have thoughts on the messaging? Currently it says:

*Hide Irrelevant Subtasks*

<a href="{0}">Click here</a> to hide subtasks that do not match any of your queries. 
This will not delete anything from your task list; you can always find hidden tasks by typing in the find box. You can change this setting under 
Advanced Filters in the Task List view menu.

Comment 12 Sam Davis 2013-02-06 20:06:10 EST

Thanks for the revew, I'll take another look at whether it's possible to reuse the control.

Comment 13 Sam Davis 2013-03-13 16:25:52 EDT

I've pushed a new change that reuses the existing control to https://git.eclipse.org/r/#change,7340, and created the following review for the needed commons change:

11130: 360055: prompt users to disable "Show subtasks not Matching Query" [I86c8616a]
https://git.eclipse.org/r/#/c/11130/

Comment 14 Sam Davis 2013-05-07 18:40:34 EDT

I've merged the change at https://git.eclipse.org/r/#/c/12599/

I changed the message to:

h3. Hide Irrelevant Subtasks

<a href="{0}">Click here</a> to disable incoming notifications for subtasks that do not match 
any of your queries. These tasks will be hidden but you can find them by typing in the find box. You can change this setting under 
Advanced Filters in the Task List view menu.

Comment 15 David Green 2013-05-07 19:04:38 EDT

Should this be default enabled for new installations (so that new users don't have the prompt?)

Comment 16 Sam Davis 2013-05-07 19:35:45 EDT

Yes, that's exactly what was implemented.