Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 360054

Summary: closing internal browser can hang Eclipse UI
Product: [Eclipse Project] Platform Reporter: Jeremiah Swan <swanj>
Component: SWTAssignee: Platform-SWT-Inbox <platform-swt-inbox>
Status: CLOSED DUPLICATE QA Contact:
Severity: critical    
Priority: P3 CC: eclipse.felipe, grant_gayed, remy.suen
Version: 3.7.1   
Target Milestone: ---   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
screencap of IE dialog, which cannot be clicked on or closed
none
simple HTML file that I use to initially open the internal browser
none
javacore of the hung Eclipse UI none

Description Jeremiah Swan CLA 2011-10-05 18:35:37 EDT
Build Identifier: Version: 3.7.1 Build id: M20110909-1335

Javacore (attached) shows the main thread is stuck in a org/eclipse/swt/internal/ole/win32/COM.VtblCall as a result of trying to close the browser.

Reproducible: Always

Steps to Reproduce:
1. Open any simple HTML file in the internal browser (it uses IE on my machines).

2. In the internal browser address bar, go to an address that you know will take a long time to load, such as a bugzilla query like https://bugs.eclipse.org/bugs/buglist.cgi?query_format=specific&order=relevance+desc&bug_status=__all__&product=&content=close+browser+hang

3. While the browser is loading, close it.  I get an "Internet Explorer Script error dialog" saying "An error has occurred in the script on this page" and asks if I want to continue running scripts on the page (but I cannot click the yes/no buttons).  Meanwhile, the Eclipse UI is completely hung and does not respond to any interaction, and must be killed from Task Manager.
Comment 1 Jeremiah Swan CLA 2011-10-05 18:36:31 EDT
Created attachment 204646 [details]
screencap of IE dialog, which cannot be clicked on or closed
Comment 2 Jeremiah Swan CLA 2011-10-05 18:37:27 EDT
Created attachment 204647 [details]
simple HTML file that I use to initially open the internal browser
Comment 3 Jeremiah Swan CLA 2011-10-05 18:37:59 EDT
Created attachment 204648 [details]
javacore of the hung Eclipse UI
Comment 4 Jeremiah Swan CLA 2011-10-05 18:43:09 EDT
I've tried this with 371 and 362 on WinXP and Win7 using IE 8

This is the simplest example I could find to reproduce the problem, although it can also been seen when you are debugging a JSP and close the browser while stopped at a breakpoint, for instance (which is the real user scenario that motivated this bug report).  In each case, IE presents a script error dialog which cannot be dismissed, and the Eclipse UI remains frozen
Comment 5 Grant Gayed CLA 2011-10-13 16:17:35 EDT
The root cause of this is the same as bug 311192, so marking report as a duplicate.  Your test case reproduces the problem reliably for me, so hopefully it can now be resolved.

*** This bug has been marked as a duplicate of bug 311192 ***