Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 360031

Summary:	should editor use sprites for annotation icons
Product:	[ECD] Orion	Reporter:	Susan McCourt <susan>
Component:	Editor	Assignee:	Project Inbox <orion.editor-inbox>
Status:	RESOLVED WONTFIX	QA Contact:
Severity:	normal
Priority:	P3	CC:	eclipse.felipe, Silenio_Quarti
Version:	unspecified
Target Milestone:	---
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Susan McCourt

2011-10-05 16:05:44 EDT

in bug 349237 I converted most of our icons to sprites.
I did not do the editor icons, such as annotations.
If editor annotations can be contributed by a plug-in, then the editor will have to be able to deal with single images anyway.  Wasn't sure it was worth the effort to do sprites since the annotations appear only as needed.

Opening a bug so the experts can decide.

Comment 1 Felipe Heidrich

2011-10-06 09:51:04 EDT

I think it is work, when the application changes the look (or the theme), all the css files will change and the editor will get new images and styles like any other component.
It also solve all the relative path problems with have (see bug 359718), which for us is even worse because of our iframe.

We have most of the code ready and it will probably be released today.

Comment 2 Felipe Heidrich

2011-12-05 16:16:16 EST

Decided not to use sprites for now.
All our default images are using data uri, there is no time download images (it is all in the css).

Please reopen it if you disagree from the above.