Bugzilla – Full Text Bug Listing
| Summary: | Changes to be made to the SQL access specification attached to 355573 | ||||||
|---|---|---|---|---|---|---|---|
| Product: | z_Archived | Reporter: | Joseph Vincens <jvincens> | ||||
| Component: | EDT | Assignee: | Justin Spadea <jspadea> | ||||
| Status: | ASSIGNED --- | QA Contact: | |||||
| Severity: | enhancement | ||||||
| Priority: | P3 | CC: | hoffmanp, jspadea, margolis, tww | ||||
| Version: | unspecified | ||||||
| Target Milestone: | --- | ||||||
| Hardware: | PC | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
|
Description
Joseph Vincens
missing () foreach myCust from rs should be foreach(myCust from rs) example causes compilation error, missing ?. rs SQLResultSet; should be rs SQLResultSet?; The following should be added to SQLResultSet: function getWarnings() returns(SQLWarning?); changing this to an enhancement so that it's not included in the weekly defect count. Page 39 the syntax for the open statement begins with "Get_statement ::=" but it should be "Open_statement ::=". Page 46: "The data_source_expr element in the TO clause must be of type eglx.persistence.sql.SQLResultSet" "TO" should be "FROM" incorporate comments and examples from 360486 and 360487 The replace statement says the syntax is "update action_target" but it should read "replace action_target". Page 50/51. The spec is missing a section for the Close statement. It's mentioned on page 6 but not further down in the spec where the details for each action statement are explained. Follow-up to previous comment: do we even need a close statement? Why not just add a close() function to SQLResultSet and SQLDataSource? incorporate annotation from 360260 into the spec The replace and delete statements say the following: "The action target action_target must be typed to a single valued type" It should become: (Replace) "The action target action_target must be a data_expr" (Delete) "The action_target if present must be a data_expr" The Get statement's target needs to include data_expr: Get_statement ::= get data_expr | action_targets [from data_source_expr] [using_clause] [with_clause]; For GET statements: If the targets are primitives mapping to columns and they do not all map to a single table, then the WITH clause is required. For ADD statements: If the targets are primitives mapping to columns and they do not all map to a single table, then the FOR clause is required. For the GET action the target fields are populated in the order of the columns in the SELECT clause. This means the SELECT column definition order must match the record field. The GET action default SQL uses an RTRIM(<col name>) for all target fields defined as strings. The syntax for the OPEN statement has a duplicate for_clause. It should be: Open_statement ::= open sql_statement_expr [from data_source_expr] [using_clause] [with_clause | for_clause]; Created attachment 206713 [details]
EDT Extension_SQLAccess_v032
I have updated and attached the SQL specification based on the comments.
Could you please review the changes and once everything looks good I'll merge all of the editing changes, check the formating, and attach the new version to 355573. Once you are done change the status to resolved. thanks |