Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 359988

Summary:	expand/collapse icons not displaying in editor
Product:	[ECD] Orion	Reporter:	Mark Macdonald <mamacdon>
Component:	Client	Assignee:	Project Inbox <orion.client-inbox>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3
Version:	0.3
Target Milestone:	0.3 RC1
Hardware:	All
OS:	All
Whiteboard:

Description Mark Macdonald

2011-10-05 09:58:26 EDT

Orion 10/5 HEAD

1. Open a .js file that has some /** */ comment blocks
2. The collapse icon should be visible beside the /** delimiter but it is not.

Comment 1 Mark Macdonald

2011-10-05 10:12:14 EDT

As part of the relative-URL work, the expand/collapse icons were changed from <img src=".."> to <img class=".."> with a background-image set by CSS. The problem here seems to be that background-image does not set the <img> element's height & width.

Comment 2 Mark Macdonald

2011-10-05 10:29:17 EDT

(In reply to comment #1)
> The problem here seems to be that background-image does not set the <img> 
> element's height & width.

This can be fixed in CSS by setting height & width explicitly (and display:block since apparently inline elements do not support this). The image then appears.

Unfortunately I also get a grey line around the image in WebKit and IE.

Comment 3 Mark Macdonald

2011-10-05 11:34:06 EDT

(In reply to comment #2)
> Unfortunately I also get a grey line around the image in WebKit and IE.
Turns out this is the edge of the "broken image" icon that appears because "src" is not set on <img>. Changing to <div> avoids this.

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=25c81032eb75cda19474d8e40d021f13186c888a